🔒 Fix Prototype Pollution in setNested#2
Conversation
Fixes a prototype pollution vulnerability in the `setNested` utility function within `scripts/generate-manifest.js`. The fix explicitly skips and filters out dangerous property names (`__proto__`, `constructor`, `prototype`) during both object traversal and final assignment. Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
akutuva21
left a comment
There was a problem hiding this comment.
Reviewed in sequence. Branch now hardens nested-key assignment consistently in both metadata parsers, closing the prototype-pollution gap.
🎯 What: The
setNestedfunction inscripts/generate-manifest.jswas vulnerable to Prototype Pollution. It allowed malicious payloads to construct or modify paths containing__proto__,constructor, orprototype, traversing up to the global prototype object.Object.prototype. This can lead to arbitrary code execution, denial of service (DoS), or logic manipulation of the JavaScript runtime.🛡️ Solution: Added an explicit check within the traversal loop to skip (
continue) any key matching__proto__,constructor, orprototype. Additionally, applied the same check to the final assignment step (returnearly) so that the global prototype/constructor itself cannot be re-assigned. This completely mitigates the vulnerability insetNested.PR created automatically by Jules for task 15072088604429859966 started by @akutuva21