Skip to content

🔒 Fix Prototype Pollution in setNested#2

Merged
akutuva21 merged 3 commits intomasterfrom
security-fix-prototype-pollution-15072088604429859966
Apr 13, 2026
Merged

🔒 Fix Prototype Pollution in setNested#2
akutuva21 merged 3 commits intomasterfrom
security-fix-prototype-pollution-15072088604429859966

Conversation

@akutuva21
Copy link
Copy Markdown
Owner

🎯 What: The setNested function in scripts/generate-manifest.js was vulnerable to Prototype Pollution. It allowed malicious payloads to construct or modify paths containing __proto__, constructor, or prototype, traversing up to the global prototype object.

⚠️ Risk: If an attacker provided a crafted input, they could manipulate the global Object.prototype. This can lead to arbitrary code execution, denial of service (DoS), or logic manipulation of the JavaScript runtime.

🛡️ Solution: Added an explicit check within the traversal loop to skip (continue) any key matching __proto__, constructor, or prototype. Additionally, applied the same check to the final assignment step (return early) so that the global prototype/constructor itself cannot be re-assigned. This completely mitigates the vulnerability in setNested.


PR created automatically by Jules for task 15072088604429859966 started by @akutuva21

Fixes a prototype pollution vulnerability in the `setNested` utility function within `scripts/generate-manifest.js`. The fix explicitly skips and filters out dangerous property names (`__proto__`, `constructor`, `prototype`) during both object traversal and final assignment.

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown
Owner Author

@akutuva21 akutuva21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in sequence. Branch now hardens nested-key assignment consistently in both metadata parsers, closing the prototype-pollution gap.

@akutuva21 akutuva21 merged commit 13a88be into master Apr 13, 2026
@akutuva21 akutuva21 deleted the security-fix-prototype-pollution-15072088604429859966 branch April 13, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant