Skip to content

🧪 Add comprehensive unit tests for parseMetadataYaml#44

Merged
akutuva21 merged 3 commits intomasterfrom
test-parse-metadata-yaml-1606873748038863229
May 3, 2026
Merged

🧪 Add comprehensive unit tests for parseMetadataYaml#44
akutuva21 merged 3 commits intomasterfrom
test-parse-metadata-yaml-1606873748038863229

Conversation

@akutuva21
Copy link
Copy Markdown
Owner

🎯 What: The testing gap for parseMetadataYaml and its helper parseScalar in scripts/validate-metadata.js has been addressed. The previous tests indirectly covered some paths via full file validation, but the custom YAML parsing logic needed isolated unit tests to handle all permutations.

📊 Coverage: The new tests cover:

  • Primitive data type parsing (true, false, null, integers, quoted/unquoted strings, inline arrays).
  • Nested object and deeply nested structure formation.
  • Array list formation (- item) under specific keys like tags, and ignoring list items that fall under other invalid keys.
  • Prototype pollution attacks (__proto__, constructor, prototype).
  • Formatting edge cases like Windows CR LF newlines, empty lines, comments, invalid non-colon lines, and multi-level un-indenting correctly popping the parse stack.
  • Dynamic key recreation when array/primitives conflict with objects.

Result: 100% test coverage has been achieved for parseMetadataYaml and parseScalar, making the custom parser robust against subtle regressions and structurally malformed metadata inputs.


PR created automatically by Jules for task 1606873748038863229 started by @akutuva21

Add detailed test cases for `parseMetadataYaml` and `parseScalar` to `scripts/validate-metadata.test.js`, covering complex YAML parsing logic and prototype pollution defense.

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@akutuva21
Copy link
Copy Markdown
Owner Author

pull the latest code and resolve merge conflicts

google-labs-jules Bot and others added 2 commits May 3, 2026 18:51
Add detailed test cases for `parseMetadataYaml` and `parseScalar` to `scripts/validate-metadata.test.js`, covering complex YAML parsing logic and prototype pollution defense. Resolved merge conflicts.

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@akutuva21 akutuva21 marked this pull request as ready for review May 3, 2026 20:02
@akutuva21 akutuva21 merged commit 6b11baa into master May 3, 2026
1 check passed
@akutuva21 akutuva21 deleted the test-parse-metadata-yaml-1606873748038863229 branch May 3, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant