fix(run-panel): pin scroll to latest message when opening a task - #3
Merged
alamops merged 1 commit intoMay 19, 2026
Merged
Conversation
Reset nearBottomRef on task switch and add a short rAF loop keyed on task.id so multi-frame layout (markdown, code blocks, tool results) can't leave the viewport short of the most recent message. Both scroll paths share the nearBottomRef gate, so a user who scrolls up during the open window is never yanked back down.
alamops
added a commit
that referenced
this pull request
Jun 29, 2026
alamops
added a commit
that referenced
this pull request
Jul 8, 2026
Rounds out the PR action set:
- reopenGitHubPull(): PATCH /pulls/:n {state:"open"} — symmetric with the
existing close. New POST /github/pull-reopen route + api client. A
"Reopen" button replaces the "closed" note in the Actions header.
- setGitHubPullDraft(): REST has no draft toggle, so it reads the PR's
node id then runs the GraphQL convertPullRequestToDraft /
markPullRequestReadyForReview mutation. New POST /github/pull-draft route
+ api client. A "Convert to draft" / "Mark ready for review" button shows
in the Actions header for open PRs; toggling refreshes mergeability
(draft flips mergeable_state).
- Tests: draftFromGraphql parsing via __githubInternals.
alamops
added a commit
that referenced
this pull request
Jul 8, 2026
… reopened row, test graphql errors Addresses the batch #3 review: - Add mergedAt to GitHubListItem (normalizeItem reads merged_at). The row header now badges merged PRs violet + "merged" (vs rose "closed"), which state:"closed" alone conflated. - Reopen is shown only for closed-unmerged PRs; merged PRs show a "Merged" note instead of a button that always 422s. - upsertListItem gains keepIfPresent so a reopened row stays visible under a "closed" filter (drops out on next refresh) instead of vanishing with an unseen success message. - Extract graphqlErrorMessage() from setGitHubPullDraft and unit-test it (first message, non-string message fallback, empty/missing errors).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset nearBottomRef on task switch and add a short rAF loop keyed on task.id so multi-frame layout (markdown, code blocks, tool results) can't leave the viewport short of the most recent message. Both scroll paths share the nearBottomRef gate, so a user who scrolls up during the open window is never yanked back down.