Handle single column tables #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhauru
approved these changes
Jan 20, 2023
Collaborator
mhauru
left a comment
mhauru
left a comment
There was a problem hiding this comment.
Looks good. We may run into issues at some point if the primary key carries some important information, right? Not that that should be addressed in this PR.
Collaborator
Author
|
Yes, we presume that the primary key will be auto-populated and that it doesn't have any meaning. There are lots of cases where that isn't true and I'm not sure what would happen if we came across a composite primary key either. |
tim-band
pushed a commit
to tim-band/sqlsynthgen
that referenced
this pull request
May 27, 2025
tim-band
added a commit
to tim-band/sqlsynthgen
that referenced
this pull request
Jun 2, 2025
…n-turing-institute#37) * Fixes alan-turing-institute#33, alan-turing-institute#34, alan-turing-institute#31 * documentation normal->generate --------- Co-authored-by: Tim Band <t.b@ucl>
tim-band
added a commit
to tim-band/sqlsynthgen
that referenced
this pull request
Jun 2, 2025
* Fixes alan-turing-institute#33, alan-turing-institute#34, alan-turing-institute#31 * documentation normal->generate * Don't unnecessarily create schema * dump-data command alan-turing-institute#38 * Initial documentation of orm.yaml --------- Co-authored-by: Tim Band <t.b@ucl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we did nothing (
continued) if we came across a primary key. This has the problem that tables with a single, PK, column end up with an empty__init__()method.