Skip to content

Handle single column tables #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Handle single column tables #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef8dbf
Order dict keys alphabetically
Iain-S Jan 19, 2023
a0b528b
Handle tables with only one column, which is a PK
Iain-S Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions sqlsynthgen/make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,14 @@ def make_generators_from_tables(tables_module: ModuleType) -> str:
sql_to_mimesis_map = {
sqltypes.BigInteger: "generic.numeric.integer_number()",
sqltypes.Boolean: "generic.development.boolean()",
sqltypes.DateTime: "generic.datetime.datetime()",
sqltypes.Date: "generic.datetime.date()",
sqltypes.Integer: "generic.numeric.integer_number()",
sqltypes.Text: "generic.text.color()",
sqltypes.DateTime: "generic.datetime.datetime()",
sqltypes.Float: "generic.numeric.float_number()",
sqltypes.Integer: "generic.numeric.integer_number()",
sqltypes.LargeBinary: "generic.binary_provider.bytes()",
sqltypes.Numeric: "generic.numeric.float_number()",
sqltypes.String: "generic.text.color()",
sqltypes.Text: "generic.text.color()",
}

for table in tables_module.Base.metadata.sorted_tables:
Expand All @@ -60,9 +62,9 @@ def make_generators_from_tables(tables_module: ModuleType) -> str:
for column in table.columns:
# We presume that primary keys are populated automatically
if column.primary_key:
continue
new_content += f"{INDENTATION*2}pass\n"

if column.foreign_keys:
elif column.foreign_keys:
if len(column.foreign_keys) > 1:
raise NotImplementedError("Can't handle multiple foreign keys.")
fkey = column.foreign_keys.pop()
Expand All @@ -74,8 +76,8 @@ def make_generators_from_tables(tables_module: ModuleType) -> str:
f'"{fk_schema}", "{fk_table}", "{fk_column}"'
")\n"
)
else:

else:
new_content += (
INDENTATION * 2
+ "self."
Expand Down
12 changes: 12 additions & 0 deletions tests/examples/example_orm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,15 @@ class HopsitalVisit(Base):
visit_end = Column(Date)
visit_duration_seconds = Column(Float)
visit_image = Column(LargeBinary)


class Entity(Base):
__tablename__ = "entity"
__table_args__ = {"schema": "myschema"}

# NB Do not add any more columns to this table as
# we use it to test what happens in the one-column case
entity_id = Column(
Integer,
primary_key=True,
)
8 changes: 8 additions & 0 deletions tests/examples/expected_ssg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,14 @@
generic.add_provider(BinaryProvider)


class entityGenerator:
def __init__(self, db_connection):
pass


class personGenerator:
def __init__(self, db_connection):
pass
self.name = generic.text.color()
self.nhs_number = generic.text.color()
self.research_opt_out = generic.development.boolean()
Expand All @@ -19,6 +25,7 @@ def __init__(self, db_connection):

class hospital_visitGenerator:
def __init__(self, db_connection):
pass
self.person_id = generic.foreign_key_provider.key(db_connection, "myschema", "person", "person_id")
self.visit_start = generic.datetime.datetime()
self.visit_end = generic.datetime.date()
Expand All @@ -27,6 +34,7 @@ def __init__(self, db_connection):


sorted_generators = [
entityGenerator,
personGenerator,
hospital_visitGenerator,
]