Skip to content

k8s upgrade require#361

Merged
chinameok merged 1 commit intomasterfrom
AIT-63431
Nov 30, 2025
Merged

k8s upgrade require#361
chinameok merged 1 commit intomasterfrom
AIT-63431

Conversation

@chinameok
Copy link
Copy Markdown
Contributor

@chinameok chinameok commented Nov 30, 2025

Summary by CodeRabbit

  • Documentation
    • Updated upgrade documentation with new Kubernetes version upgrade policy. Starting from ACP 4.2, Kubernetes upgrades are now mandatory during platform cluster upgrades, no longer optional. This applies to both global and workload cluster upgrade procedures, ensuring version consistency across deployments.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 30, 2025

Walkthrough

Documentation updates to enforce that Kubernetes version upgrades are no longer optional during platform upgrades starting from ACP 4.2. Three upgrade-related documentation files are updated to remove guidance stating upgrades were optional and replace it with mandatory upgrade policy statements.

Changes

Cohort / File(s) Change Summary
Kubernetes Upgrade Policy Updates
docs/en/overview/release_notes.mdx, docs/en/upgrade/upgrade_global_cluster.mdx, docs/en/upgrade/upgrade_workload_cluster.mdx
Removed guidance stating Kubernetes version upgrades are optional and replaced with policy requiring Kubernetes upgrades to be performed with other platform components during cluster upgrades starting from ACP 4.2. Removed reference to ACP GitOps plugin upgrade procedure in global cluster documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Documentation-only changes with straightforward policy clarifications
  • No code logic or structural changes
  • Consistent theme across all three files (Kubernetes upgrade policy enforcement)

Possibly related PRs

Poem

🐰 Kubernetes must upgrade, no more to choose—
We're bundling it tight, no version to lose!
From ACP 4.2, the new rule takes flight,
Each upgrade together, we'll keep things just right! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'k8s upgrade require' is partially related to the changeset, referring to the Kubernetes version upgrade policy changes, but is incomplete, grammatically awkward, and lacks clarity about the specific requirement being enforced. Revise the title to be more complete and grammatically correct, such as 'Make Kubernetes upgrades mandatory during platform updates' or 'Enforce Kubernetes version upgrade with platform components'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch AIT-63431

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/en/overview/release_notes.mdx (1)

45-50: Consider moving the policy update to a dedicated section.

The "Kubernetes Version Upgrade Policy Update" logically describes a policy change rather than a deprecated or removed feature. Placing it under "Deprecated and Removed Features" may confuse readers about its nature.

Consider adding a new top-level subsection such as "Policy Changes" or "Breaking Changes" at the same level as "Deprecated and Removed Features" to house this policy update. This would improve documentation structure and make the mandatory upgrade requirement more discoverable.

Example refactor:

 ### Deprecated and Removed Features

-#### Kubernetes Version Upgrade Policy Update
-
-Starting from **ACP 4.2**, upgrading the Kubernetes version is **no longer optional**. When performing a cluster upgrade, the Kubernetes version must be upgraded together with other platform components.
-This change ensures version consistency across the cluster and reduces future maintenance windows.

+### Policy Changes
+
+#### Kubernetes Version Upgrade Policy Update
+
+Starting from **ACP 4.2**, upgrading the Kubernetes version is **no longer optional**. When performing a cluster upgrade, the Kubernetes version must be upgraded together with other platform components.
+This change ensures version consistency across the cluster and reduces future maintenance windows.

 ### Fixed Issues

Alternatively, if this must remain under "Deprecated and Removed Features," consider adding a brief clarification in the subsection title (e.g., "Kubernetes Version Upgrade Policy Update (mandatory starting ACP 4.2)") to signal the policy nature upfront.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e1083b6 and 7a82fcf.

📒 Files selected for processing (3)
  • docs/en/overview/release_notes.mdx (1 hunks)
  • docs/en/upgrade/upgrade_global_cluster.mdx (0 hunks)
  • docs/en/upgrade/upgrade_workload_cluster.mdx (0 hunks)
💤 Files with no reviewable changes (2)
  • docs/en/upgrade/upgrade_workload_cluster.mdx
  • docs/en/upgrade/upgrade_global_cluster.mdx
🔇 Additional comments (1)
docs/en/overview/release_notes.mdx (1)

47-50: Verify upstream upgrade procedure documentation is clear.

The release note clearly states the mandatory policy but does not explain how to perform the upgrade. Per the PR context, other files in this PR (e.g., upgrade_global_cluster.mdx, upgrade_workload_cluster.mdx) removed optional-upgrade guidance but did not add replacement guidance.

Confirm that the upgrade procedure documentation in those files has been updated (or will be updated in a follow-up) with clear step-by-step instructions for performing the mandatory Kubernetes upgrade. This will prevent users from encountering the policy requirement without actionable guidance.

@chinameok chinameok merged commit c1788b7 into master Nov 30, 2025
2 of 3 checks passed
@chinameok chinameok deleted the AIT-63431 branch November 30, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant