Skip to content

Revert "Add warnings for ACP 4.2.1 upgrade known issues"#507

Closed
chinameok wants to merge 1 commit intomasterfrom
revert-505-AIT-66247
Closed

Revert "Add warnings for ACP 4.2.1 upgrade known issues"#507
chinameok wants to merge 1 commit intomasterfrom
revert-505-AIT-66247

Conversation

@chinameok
Copy link
Copy Markdown
Contributor

@chinameok chinameok commented Jan 14, 2026

Reverts #505

Summary by CodeRabbit

  • Documentation
    • Applied minor formatting and spacing improvements to upgrade procedure guides across global and workload cluster upgrade workflows and configurations.
    • Removed previously documented ACP 4.2.1 known issue warnings that provided important guidance on potential component downgrade behavior and risks.
    • Introduced a typo in the cluster authentication documentation section.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 14, 2026

Walkthrough

Documentation updates to upgrade guides removing Known Issue warning blocks for ACP 4.2.1 from two files. A typo ("awared" instead of "aware") is introduced in one location. Overall content is simplified with elimination of cautionary guidance about downgrade behavior.

Changes

Cohort / File(s) Summary
Documentation Warning Removals
docs/en/upgrade/upgrade_global_cluster.mdx
Removed multi-line Known Issue ACP 4.2.1 warning block about downgrade behavior; minor formatting adjustments in INFO/warning blocks; introduced typo "awared" in standby cluster authentication note (+4/-21 lines)
Documentation Warning Removals
docs/en/upgrade/upgrade_workload_cluster.mdx
Removed Known Issue ACP 4.2.1 warning block from workflow steps section; eliminated admonition with example explanation about re-clicking Upgrade button (+0/-8 lines)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • youyongsong

Poem

🐰 A warning takes flight, swept clean away,
Known issues banished from the upgrade display,
Though a typo hops in where "aware" should be,
Documentation lighter, simplified and free! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly and accurately reflects the main change: reverting a previous commit that added ACP 4.2.1 upgrade warnings. It is concise, specific, and clearly communicates the primary action being taken.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@docs/en/upgrade/upgrade_global_cluster.mdx`:
- Line 46: Fix the typo in the sentence by replacing "awared" with "aware" so
the line reads: "Also be aware that either authentication info of the standby
cluster's image registry or `--no-auth` parameter MUST be provided."
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 30351f2 and 1f3b65d.

📒 Files selected for processing (2)
  • docs/en/upgrade/upgrade_global_cluster.mdx
  • docs/en/upgrade/upgrade_workload_cluster.mdx
💤 Files with no reviewable changes (1)
  • docs/en/upgrade/upgrade_workload_cluster.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pipelines as Code CI / doc-pr-build-container-platform
🔇 Additional comments (1)
docs/en/upgrade/upgrade_global_cluster.mdx (1)

36-40: LGTM!

The INFO block content is clear and provides appropriate guidance for DR-configured platforms.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Otherwise, the packages will be uploaded to the image repository of the **primary cluster**, preventing the standby cluster from installing or upgrading extensions.

Also be aware that either authentication info of the standby cluster's image registry or `--no-auth` parameter MUST be provided.
Also be awared that either authentication info of the standby cluster's image registry or `--no-auth` parameter MUST be provided.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: "awared" should be "aware".

The word "awared" is not valid English. This should be corrected to "aware".

📝 Suggested fix
-Also be awared that either authentication info of the standby cluster's image registry or `--no-auth` parameter MUST be provided.
+Also be aware that either authentication info of the standby cluster's image registry or `--no-auth` parameter MUST be provided.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Also be awared that either authentication info of the standby cluster's image registry or `--no-auth` parameter MUST be provided.
Also be aware that either authentication info of the standby cluster's image registry or `--no-auth` parameter MUST be provided.
🤖 Prompt for AI Agents
In `@docs/en/upgrade/upgrade_global_cluster.mdx` at line 46, Fix the typo in the
sentence by replacing "awared" with "aware" so the line reads: "Also be aware
that either authentication info of the standby cluster's image registry or
`--no-auth` parameter MUST be provided."

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying alauda-container-platform with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1f3b65d
Status: ✅  Deploy successful!
Preview URL: https://f6aec833.alauda-container-platform.pages.dev
Branch Preview URL: https://revert-505-ait-66247.alauda-container-platform.pages.dev

View logs

@chinameok chinameok closed this Jan 14, 2026
@chinameok chinameok deleted the revert-505-AIT-66247 branch January 14, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant