Conversation
🦋 Changeset detectedLatest commit: 070c8ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
WalkthroughThis PR relocates the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR addresses an @eslint/js resolution error by ensuring the package that actually imports it (@alauda/doom) declares it as a dependency, and updates the lockfile and changeset accordingly.
Changes:
- Add
@eslint/jstopackages/doomdependencies. - Remove
@eslint/jsfrom the rootpackage.jsondevDependencies. - Add a changeset to publish a patch release of
@alauda/doom.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| yarn.lock | Reflects dependency graph changes for @eslint/js across workspaces. |
| packages/doom/package.json | Declares @eslint/js as a dependency for the @alauda/doom package. |
| package.json | Removes @eslint/js from root devDependencies (may create a phantom dependency for root tooling). |
| .changeset/goofy-monkeys-train.md | Adds a patch changeset for @alauda/doom describing the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| "devDependencies": { | ||
| "@changesets/changelog-github": "^0.6.0", | ||
| "@changesets/cli": "^2.30.0", | ||
| "@eslint/js": "^10.0.1", | ||
| "@swc-node/register": "^1.11.1", |
There was a problem hiding this comment.
@eslint/js is still imported by the repo-level eslint.config.js, but it’s no longer declared in the root package.json. With Yarn’s node-modules linker this can become a phantom dependency (working only via hoisting) and may break yarn lint/CI if hoisting changes. Please either re-add @eslint/js to the root devDependencies, or refactor the root ESLint config to avoid importing it directly.
Summary by CodeRabbit
Release Notes