Skip to content

fix: @eslint/js not found issue#280

Merged
JounQin merged 1 commit intomainfrom
fix/eslint
Mar 12, 2026
Merged

fix: @eslint/js not found issue#280
JounQin merged 1 commit intomainfrom
fix/eslint

Conversation

@JounQin
Copy link
Copy Markdown
Member

@JounQin JounQin commented Mar 12, 2026

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Resolved "@eslint/js not found" error affecting code linting functionality.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 12, 2026

🦋 Changeset detected

Latest commit: 070c8ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alauda/doom Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI review requested due to automatic review settings March 12, 2026 07:43
@JounQin JounQin merged commit d9a1cef into main Mar 12, 2026
12 of 13 checks passed
@JounQin JounQin deleted the fix/eslint branch March 12, 2026 07:44
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 12, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e852b3b1-3e87-4979-9b4f-6b4b4e766eb2

📥 Commits

Reviewing files that changed from the base of the PR and between a70be23 and 070c8ca.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • .changeset/goofy-monkeys-train.md
  • package.json
  • packages/doom/package.json

Walkthrough

This PR relocates the @eslint/js dependency from the root package's devDependencies to the packages/doom package's dependencies, fixing a "not found" issue. A changeset file documenting the patch release is also added.

Changes

Cohort / File(s) Summary
Changeset
.changeset/goofy-monkeys-train.md
New changeset file added documenting a patch release for @alauda/doom with fix message regarding @eslint/js not found issue.
Dependency Migration
package.json, packages/doom/package.json
Removed @eslint/js from root devDependencies and added it to packages/doom dependencies to resolve resolution issues.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

dependencies

Poem

🐰 A rabbit hops with glee,
Moving eslint from root to tree,
packages/doom now claims its own,
No more "not found" in the zone! 🎉
Dependencies dance, at last set free! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/eslint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an @eslint/js resolution error by ensuring the package that actually imports it (@alauda/doom) declares it as a dependency, and updates the lockfile and changeset accordingly.

Changes:

  • Add @eslint/js to packages/doom dependencies.
  • Remove @eslint/js from the root package.json devDependencies.
  • Add a changeset to publish a patch release of @alauda/doom.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
yarn.lock Reflects dependency graph changes for @eslint/js across workspaces.
packages/doom/package.json Declares @eslint/js as a dependency for the @alauda/doom package.
package.json Removes @eslint/js from root devDependencies (may create a phantom dependency for root tooling).
.changeset/goofy-monkeys-train.md Adds a patch changeset for @alauda/doom describing the fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread package.json
Comment on lines 33 to 36
"devDependencies": {
"@changesets/changelog-github": "^0.6.0",
"@changesets/cli": "^2.30.0",
"@eslint/js": "^10.0.1",
"@swc-node/register": "^1.11.1",
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eslint/js is still imported by the repo-level eslint.config.js, but it’s no longer declared in the root package.json. With Yarn’s node-modules linker this can become a phantom dependency (working only via hoisting) and may break yarn lint/CI if hoisting changes. Please either re-add @eslint/js to the root devDependencies, or refactor the root ESLint config to avoid importing it directly.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants