Conversation
🦋 Changeset detectedLatest commit: a180751 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
WalkthroughThis PR pins ESLint to v9 across the repo (root and packages/doom), removes a local eslint-plugin-mdx remark rule patch, adds a changeset noting the temporary ESLint 9 pin, and configures Renovate to ignore Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Pull request overview
This PR temporarily downgrades ESLint from version 10.x to 9.39.3 to address compatibility issues in the ecosystem. The downgrade includes updating both the core ESLint package and its companion @eslint/js package, and prevents automatic upgrades by adding these packages to Renovate's ignore list.
Changes:
- Downgrade ESLint from ^10.0.2 to ^9.39.3 and
@eslint/jsfrom ^10.0.1 to ^9.0.0 across package.json files - Remove the eslint-plugin-mdx patch that was needed for ESLint 10 API compatibility
- Add ESLint packages to Renovate's ignoreDeps list to prevent automatic upgrades
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Downgrade @eslint/js to ^9.0.0 and eslint to ^9.39.3 in root devDependencies |
| packages/doom/package.json | Downgrade eslint to ^9.39.3 in doom package dependencies |
| yarn.lock | Update all ESLint-related dependencies and their transitive dependencies to versions compatible with ESLint 9, including downgrading eslint-scope, espree, and related packages |
| .renovaterc | Add @eslint/js and eslint to ignoreDeps to prevent automatic version updates |
| patches/eslint-plugin-mdx+3.6.2.patch | Remove patch that adapted eslint-plugin-mdx for ESLint 10's new API (no longer needed with ESLint 9) |
| .changeset/gentle-stamps-stop.md | Add changeset documenting the temporary ESLint 9 pin as a patch release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.renovaterc (1)
6-10: Confirm the Renovate ignore list is intentionally blocking ESLint updates.
Line 6-10 now prevents Renovate from proposing@eslint/js/eslintbumps; please ensure there’s a tracked reminder to re-enable updates once the temporary pin ends.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.renovaterc around lines 6 - 10, The Renovate ignore list currently includes "@eslint/js" and "eslint" under the "ignoreDeps" array which prevents Renovate from proposing ESLint-related updates; remove or comment these entries or add a clear TODO/token so they can be re-enabled later, and create a tracked reminder (e.g., an issue or project card) referencing the ignore list entries "@eslint/js" and "eslint" to re-enable updates when the temporary pin ends; update the .renovaterc "ignoreDeps" accordingly and ensure the reminder includes the reason and an expected re-enable date.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.renovaterc:
- Around line 6-10: The Renovate ignore list currently includes "@eslint/js" and
"eslint" under the "ignoreDeps" array which prevents Renovate from proposing
ESLint-related updates; remove or comment these entries or add a clear
TODO/token so they can be re-enabled later, and create a tracked reminder (e.g.,
an issue or project card) referencing the ignore list entries "@eslint/js" and
"eslint" to re-enable updates when the temporary pin ends; update the
.renovaterc "ignoreDeps" accordingly and ensure the reminder includes the reason
and an expected re-enable date.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
.changeset/gentle-stamps-stop.md.renovatercpackage.jsonpackages/doom/package.jsonpatches/eslint-plugin-mdx+3.6.2.patch
💤 Files with no reviewable changes (1)
- patches/eslint-plugin-mdx+3.6.2.patch
Summary by CodeRabbit
Release Notes