Conversation
🦋 Changeset detectedLatest commit: f4ea005 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 21 minutes and 40 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
WalkthroughUpgrades ESLint from v9.39.3 to v10.2.0 and TypeScript from v5.9.3 to v6.0.2, along with related dependencies. Adjusts ESLint configuration for React plugin compatibility, updates lint-rule suppression directives across components, and increments Node.js engine requirement to >=22.18.0. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the repo to ESLint v10 (and aligned ecosystem packages), adjusts ESLint config/rule suppressions to match new rule IDs, and bumps runtime/tooling versions to keep the workspace consistent.
Changes:
- Bump ESLint to v10 and update related linting ecosystem dependencies (e.g.,
@eslint/js,@eslint-react/*,typescript-eslint,cspell). - Update ESLint config and inline
eslint-disablecomments to new rule names and disable some rules for MDX. - Raise
@alauda/doomNode engine requirement and publish a major changeset.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Locks updated dependency graph reflecting ESLint v10 and related bumps. |
packages/doom/src/theme/VersionsNav/index.tsx |
Adds download attribute for PDF nav item and adjusts lint suppression usage. |
packages/doom/src/theme/AutoExpandable.tsx |
Updates inline disable comment to new rule ID. |
packages/doom/src/runtime/hooks/useMemoizedFn.ts |
Removes now-unneeded inline disable for ref assignment. |
packages/doom/src/runtime/hooks/useInterval.ts |
Removes now-unneeded inline disable for ref assignment. |
packages/doom/src/runtime/components/Masonry.tsx |
Adds rule suppression for component factory inside lazy import. |
packages/doom/src/runtime/components/K8sPermissionTable.tsx |
Updates inline disable comment to new rule ID. |
packages/doom/src/runtime/components/K8sCrd.tsx |
Updates inline disable comment to new rule ID. |
packages/doom/src/eslint.ts |
Adapts config generation to ESLint v10 API/surface; adds MDX rule overrides; suppresses TS typing issues. |
packages/doom/package.json |
Bumps lint/tooling deps to match ESLint v10 and raises Node engine requirement. |
package.json |
Bumps workspace tooling deps (ESLint, TS, SWC, Prettier plugin). |
eslint.config.js |
Reorders/react plugin configs and adds conflict-disabling preset; disables additional rules for MDX. |
.changeset/five-garlics-rescue.md |
Publishes a major changeset for the ESLint v10 upgrade. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JounQin
force-pushed
the
chore/bump_eslint
branch
from
bafab02 to
f4ea005
Compare
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/doom/package.json`:
- Line 14: The package's "node" engine in packages/doom package.json is set to
">=22.18.0" which conflicts with the monorepo baseline and CI matrix; update the
engine to match the monorepo baseline by lowering it to ">=20.19.0" (to align
with packages/export and AGENTS.md) OR, if this is an intentional breaking
change, remove Node 20 from the CI matrix in .github/workflows/ci.yml and add a
note in AGENTS.md documenting the breaking change; make the change consistently
across the repo so the package.json "node" engine and the CI matrix agree.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2f18ab3f-45b8-400a-b69a-624eb637855b
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (12)
.changeset/five-garlics-rescue.mdeslint.config.jspackage.jsonpackages/doom/package.jsonpackages/doom/src/eslint.tspackages/doom/src/runtime/components/K8sCrd.tsxpackages/doom/src/runtime/components/K8sPermissionTable.tsxpackages/doom/src/runtime/components/Masonry.tsxpackages/doom/src/runtime/hooks/useInterval.tspackages/doom/src/runtime/hooks/useMemoizedFn.tspackages/doom/src/theme/AutoExpandable.tsxpackages/doom/src/theme/VersionsNav/index.tsx
💤 Files with no reviewable changes (2)
- packages/doom/src/runtime/hooks/useInterval.ts
- packages/doom/src/runtime/hooks/useMemoizedFn.ts
Summary by CodeRabbit
New Features
Chores