[docs-agent] Revert v1 Solana DAS getAsset CU 160 → 80 (keep v2 at 160)#1478
Open
alchemy-bot wants to merge 1 commit into
Open
[docs-agent] Revert v1 Solana DAS getAsset CU 160 → 80 (keep v2 at 160)#1478alchemy-bot wants to merge 1 commit into
alchemy-bot wants to merge 1 commit into
Conversation
PR #1460 (DOCS-145) bumped getAsset CU from 80 to 160 on both v1 and v2. Victor followed up asking to keep v2 at 160 but revert v1 back to 80. Reverts in three places: v1 OpenRPC spec (x-compute-units), v1 landing MDX table, and the Solana DAS APIs table on the Compute Unit Costs page. v2 spec + v2 landing page are unchanged. Note: the compute-unit-costs.mdx Solana DAS table sits inside {/* cu:auto product="solana-das" */} so the next chain-config auto-sync will restore whatever value topconfig.yml has. If topconfig.yml still shows 160, a follow-up chain-config PR would be needed to make the 80 stick. Refs DOCS-160 Requested-by: @victorbware
🔗 Preview Mode
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the v1 Solana DAS
getAssetCU cost from 160 back to 80. v2 keeps the 160 value.PR #1460 (DOCS-145) bumped
getAssetCU from 80 to 160 on both v1 and v2 per Victor's earlier feedback. Victor followed up in the same Slack thread asking to keep v2 at 160 but revert v1 back to 80.Files
src/openrpc/alchemy/solana-das/solana-das.yaml—getAsset.x-compute-units: 160→80content/api-reference/data/nft-api/alchemy-das-apis-for-solana.mdx—getAssetrow CU column:160→80content/api-reference/pricing-resources/pricing/compute-unit-costs.mdx— Solana DAS APIs tablegetAssetrow:160→80Out of scope (v2 unchanged)
src/openrpc/alchemy/solana-das-v2/solana-das-v2.yaml—getAsset_v2stays at 160content/api-reference/data/nft-api/alchemy-das-apis-for-solana-v2.mdx—getAsset_v2row stays at 160Note on auto-sync
The Compute Unit Costs page's Solana DAS table sits inside a
{/* cu:auto product="solana-das" */}marker, so the value may be overwritten on the next chain-config auto-sync. Iftopconfig.ymlinOMGWINNING/chain-configstill shows 160 forgetAsset, a follow-up chain-config PR would be needed to make the 80 stick past the next sync.Validation
pnpm run generate:rpc✅pnpm run validate:rpc✅ (both json-rpc and chains specs)pnpm exec prettier --check✅ on all three changed filesLinear
DOCS-160 — https://linear.app/alchemyapi/issue/DOCS-160/revert-v1-solana-das-getasset-cu-cost-160-80-keep-v2-at-160
Requested by
@victorbware (via Slack thread)