Add human-readable, editable URLs for uploaded elevation routes - #73
Merged
Conversation
Uploaded GPX routes now get pretty, shareable URLs of the form
/elevationfinder/{slug}-{shortId} (e.g. /elevationfinder/boston-marathon-a3f9c)
instead of an opaque Firebase doc id, matching the blog/race slug style.
- New src/lib/routeSlug.ts: slugify, generateShortId, buildRouteSlugPath,
buildRouteUrl, extractShortId helpers.
- Uploads store an editable `slug` plus an immutable base36 `shortId`; the
address bar and share link use the pretty path.
- useRouteLoader resolves a URL param via the trailing shortId, falling back to
a direct doc lookup so legacy /elevationfinder/{docId} links keep working
(Firestore auto-ids are hyphen-free, which cleanly distinguishes the two).
- Owners can rename a route's URL from the dashboard route card; the shortId is
preserved (and minted for legacy routes) so existing shared links never break.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013vrVKTbMjPPoeDcpzsPrR5
✅ Deploy Preview for trainpace ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| UnusedCode | 2 medium |
| BestPractice | 4 medium |
| ErrorProne | 2 medium 33 high |
| Complexity | 2 medium |
🟢 Metrics 73 complexity · 3 duplication
Metric Results Complexity 73 Duplication 3
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Brings in the fixed training-plan e2e spec (which now sets a valid race date and asserts the Generate button is enabled before clicking, instead of clicking it while disabled and timing out) so the e2e check passes. Conflict in GpxUploader.tsx resolved by keeping main's proceedWithUpload() refactor and threading this PR's shareable displayUrl through it, so both the refactor and the pretty-URL feature are preserved. tsc -b passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KvvBmi4SLYYP7uL5ZJ1doK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uploaded GPX routes now get pretty, shareable URLs that match the blog/race slug style, instead of an opaque Firebase doc id:
The slug is owner-editable from the dashboard; the trailing short id is the real resolution key, so renaming never breaks an existing link.
How it works
src/lib/routeSlug.ts(new) —slugify,generateShortId(6-char base36),buildRouteSlugPath,buildRouteUrl,extractShortId.slug(derived from the filename) plus an immutableshortId. The address bar and Share dialog use the pretty path.useRouteLoader): pretty{slug}-{shortId}URLs resolve on the trailingshortIdvia a Firestore query; the slug is cosmetic. URLs with no hyphen fall back to a direct doc lookup./elevationfinder/{docId}links — they route to the direct-lookup fallback and keep working.shortIdis preserved (and minted for legacy routes on first edit), so shared links never break on rename.Notes
gpx_uploadsalready allows public read (covers theshortIdquery), and single-field equality queries use the automatic index.Verification
tsc -bcleannpm run buildclean (exit 0, all 80+ prerender routes generated)console/exhaustive-deps warnings🤖 Generated with Claude Code
Generated by Claude Code