[Jobs] Split jobs in several files #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Depends on #227. |
odesenfans
force-pushed
the
od-split-jobs
branch
2 times, most recently
from
373bfb3 to
fc8517e
Compare
hoh
approved these changes
Apr 26, 2022
|
|
||
| def start_jobs( | ||
| config, | ||
| shared_stats: Dict, |
Collaborator
Author
There was a problem hiding this comment.
It is a dict. A proxy to a dict managed by a shared memory manager, but it behaves like a dict.
|
|
||
| if ( | ||
| pending["message"]["item_type"] == ItemType.IPFS | ||
| or pending["message"]["type"] == "STORE" |
Member
There was a problem hiding this comment.
Should we use aleph_message.models.MessageType.store ?
Collaborator
Author
There was a problem hiding this comment.
Yes. I'm going to create an additional PR with all your suggestions.
|
|
||
| seen_ids: Dict[Tuple, int] = dict() | ||
| gtasks: List[asyncio.Task] = [] | ||
| tasks: List[asyncio.Task] = [] |
Member
There was a problem hiding this comment.
gtasks refers here to a list of created asyncio tasks, but tasks to a list of coroutines that have not been created/started. We could improve the naming.
Collaborator
Author
There was a problem hiding this comment.
Yup. I want gtasks to disappear though so that will solve the problem entirely.
| messages = await get_chaindata_messages( | ||
| pending["content"], pending["context"], seen_ids=seen_ids | ||
| ) | ||
| if isinstance(messages, list): |
Collaborator
Author
There was a problem hiding this comment.
Because that would be too pythonic.
Split the `jobs.py` file and put each separate job in its own file. This simplifies the structure of the code. Renamed the subprocesses for pending messages and txs to make them similar.
odesenfans
force-pushed
the
od-split-jobs
branch
from
fc8517e to
bd8e0c1
Compare
odesenfans
added a commit
to odesenfans/pyaleph
that referenced
this pull request
Apr 26, 2022
Implemented two suggestions from the review of aleph-im#229.
odesenfans
added a commit
to odesenfans/pyaleph
that referenced
this pull request
Apr 26, 2022
Implemented two suggestions from the review of aleph-im#229.
odesenfans
added a commit
that referenced
this pull request
Apr 26, 2022
Implemented two suggestions from the review of #229.
odesenfans
added a commit
that referenced
this pull request
Apr 27, 2022
Split the `jobs.py` file and put each separate job in its own file. This simplifies the structure of the code. Renamed the subprocesses for pending messages and txs to make them similar.
odesenfans
added a commit
that referenced
this pull request
Apr 27, 2022
Implemented two suggestions from the review of #229.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the
jobs.pyfile and put each separate job in its ownfile. This simplifies the structure of the code.
Renamed the subprocesses for pending messages and txs to make
them similar.