Skip to content

Dockerfile and docker-compose#46

Merged
polarker merged 9 commits intoalephium:masterfrom
mauroferra:docker
Jun 12, 2022
Merged

Dockerfile and docker-compose#46
polarker merged 9 commits intoalephium:masterfrom
mauroferra:docker

Conversation

@mauroferra
Copy link
Copy Markdown
Contributor

Added a Dockerfile to build an image from the latest Git Release of the mining-pool repo, and a docker-compose file to deploy that image along with redis and a Postgres.

Readme updated to include info about docker deployment.

Comment thread docker-compose.yaml Outdated

services:
mining-pool:
image: mauroferra/mining-pool:v1.3.0
Copy link
Copy Markdown
Member

@polarker polarker Jun 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to change the prefix mauroferra?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It points to an image that I built with the Dockerfile included, which fetches the code from a release tarball, because the official mining-pool image is quite outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will not include an unofficial docker image in the reference code. Could you remove the image name and ask people to build the docker manually?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i can do that, there's the Dockerfile included just for that. I'll make 2 versions, one that uses the current context (useful for building an image from master with latest code) and one that pulls the zip from the latest release, just like it is now.

Will do in a bit today.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take your time, thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

- Added Dockerfile for local build
- Removed reference to external image
- Added instructions to build from source, latest master code and latest release
Comment thread README.md

1. From local sources:
```shell
docker build -t mining-pool:latest .
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the build: section inside of compose, you can make this automatic 👍

It will name and tag what it builds locally with what you place under image: name:tag

https://docs.docker.com/compose/compose-file/build/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I added the step and adjusted the readme

Added automatic image build step and adjusted readme
Copy link
Copy Markdown
Member

@Lbqds Lbqds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot this, just tested it, LGTM 👍

@polarker polarker merged commit c74c5ca into alephium:master Jun 12, 2022
@mauroferra mauroferra deleted the docker branch June 12, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants