Removing Shadow DOM reverence that were deprecated in atom v1.13.0 #157
Conversation
|
|
||
| @git-blame-bg-color: @base-background-color; | ||
|
|
||
| atom-text-editor::shadow .git-blame-mount, |
There was a problem hiding this comment.
based on the automatic upgrade rule, it should probably just be changed to atom-text-editor.editor .git-blame-mount, instead of deleted
There was a problem hiding this comment.
The only reverence I can find related to removing shadow dom is http://flight-manual.atom.io/shadow-dom/sections/removing-shadow-dom-styles/#shadow
By that section there is no recommendation to add .editor. The line that is removed is comes before the current correct line.
If you have an additional reference I will be glad to take a look at that.
There was a problem hiding this comment.
The original issue shows the automatic translation that atom will do. It's a little hard to see in the way it was reported, but they have the original shadow form of the selector followed by => and then the automatically transpiled version. Per the docs you are correct, though they do reference it down here: http://flight-manual.atom.io/shadow-dom/sections/removing-shadow-dom-styles/#i-followed-the-guide-but-now-my-styling-is-broken
It is a bit unclear which is preferred, but since it was automatically adding the .editor before it is fully deprecated, I think it would be good to keep that as an option for ensuring specificity is high (though I doubt that there would be a conflict with .git-blame-mount)
|
closing in favor of #160 |
3 participants
Removing Shadow DOM references that were deprecated in atom v1.13.0 to fix issue #156.