Skip to content

Removing Shadow DOM reverence that were deprecated in atom v1.13.0 #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Removing Shadow DOM reverence that were deprecated in atom v1.13.0 #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion styles/git-blame.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

@git-blame-bg-color: @base-background-color;

atom-text-editor::shadow .git-blame-mount,
atom-text-editor .git-blame-mount {
Copy link

@mstewart6 mstewart6 Feb 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the automatic upgrade rule, it should probably just be changed to atom-text-editor.editor .git-blame-mount, instead of deleted

Copy link
Author

@benwoodard benwoodard Feb 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reverence I can find related to removing shadow dom is http://flight-manual.atom.io/shadow-dom/sections/removing-shadow-dom-styles/#shadow

By that section there is no recommendation to add .editor. The line that is removed is comes before the current correct line.

If you have an additional reference I will be glad to take a look at that.

Copy link

@mstewart6 mstewart6 Feb 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original issue shows the automatic translation that atom will do. It's a little hard to see in the way it was reported, but they have the original shadow form of the selector followed by => and then the automatically transpiled version. Per the docs you are correct, though they do reference it down here: http://flight-manual.atom.io/shadow-dom/sections/removing-shadow-dom-styles/#i-followed-the-guide-but-now-my-styling-is-broken

It is a bit unclear which is preferred, but since it was automatically adding the .editor before it is fully deprecated, I think it would be good to keep that as an option for ensuring specificity is high (though I doubt that there would be a conflict with .git-blame-mount)

position: relative;

Expand Down