Added support to encode maps

[gustavs]

Added support to encode maps as parameters, simplifies integrating with Odoo XMLRPC API for example.

[Copilot]

Pull Request Overview

This PR adds support for encoding Go maps into XML-RPC <struct> elements, enabling richer parameter serialization.

• Added a new encodeMap method and hooked it into encodeValue for reflect.Map kinds
• Introduced tests in encode_test.go covering empty maps, basic types, nested maps, and non-string keys
• Defined XMLRPC* helper types in tests (currently unused)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
encode.go	Added case reflect.Map in encodeValue and new encodeMap method to serialize maps as XML-RPC structs
encode_test.go	Added Test_encodeMap with various map scenarios and helper XMLRPC* types

[Copilot]

The reflect.Map branch in encodeValue calls encodeMap without wrapping the output in tags, causing nested maps to be encoded incorrectly. Consider adding ... around encodeMap's output to match XML-RPC format.

Suggested change

	case reflect.Map:
	if err := e.encodeMap(w, value); err != nil {
	return fmt.Errorf("cannot encode map value: %w", err)
	}
	case reflect.Map:
	_, _ = fmt.Fprint(w, "<value>")
	if err := e.encodeMap(w, value); err != nil {
	return fmt.Errorf("cannot encode map value: %w", err)
	}
	_, _ = fmt.Fprint(w, "</value>")

[Copilot]

Iteration over maps in Go is non-deterministic, which may produce unstable XML output. Consider collecting and sorting the keys before encoding to ensure deterministic ordering.

[Copilot]

Write operations on io.Writer ignore errors here. It’s better to check and handle potential write errors instead of discarding them.

Suggested change

	_, _ = fmt.Fprint(w, "<struct>")
	if _, err := fmt.Fprint(w, "<struct>"); err != nil {
	return fmt.Errorf("failed to write struct start tag: %w", err)
	}

[Copilot]

The XMLRPCValue, XMLRPCMember, and XMLRPCStruct types are declared but not used in this test file. Consider removing them to reduce clutter.

Suggested change

	// XMLRPCValue represents a value in XML-RPC format
	type XMLRPCValue struct {
	Type string `xml:"type,attr"`
	Value interface{} `xml:",chardata"`
	}
	// XMLRPCMember represents a member in XML-RPC struct
	type XMLRPCMember struct {
	Name string `xml:"name"`
	Value XMLRPCValue `xml:"value"`
	}
	// XMLRPCStruct represents an XML-RPC struct
	type XMLRPCStruct struct {
	Members []XMLRPCMember `xml:"member"`
	}

[alexejk]

Thanks for the contribution. As I had to adjust a few parts of the implementation, I've rebased your commits and pushed them as part of #92 instead. I will be closing this one while wrapping up the implementation and cleanup in the other branch 🙇🏼