Implement return-type matching for method invocations in MethodMatcher#150
Merged
RadikalJin merged 1 commit intoMay 29, 2026
Merged
Conversation
Return-type matching previously only worked for MethodDeclaration nodes and was silently ignored for MethodInvocation, ClassInstanceCreation and the IMethodBinding overload. This resolves the method binding and compares the fully qualified return type (erasure for generics, void handled), sharing the comparison logic across all node kinds, with inner-class ($ -> .) normalisation and warn + non-match handling for unresolved bindings.
RadikalJin
restored the
feature/method-matcher-return-type-for-invocations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return-type matching previously only worked for MethodDeclaration nodes and was silently ignored for MethodInvocation, ClassInstanceCreation and the IMethodBinding overload. This resolves the method binding and compares the fully qualified return type (erasure for generics, void handled), sharing the comparison logic across all node kinds, with inner-class ($ -> .) normalisation and warn + non-match handling for unresolved bindings.