Conversation
|
| // xaDataSource.setURL(jdbcUrl); | ||
| // xaDataSource.setUser(username); | ||
| // xaDataSource.setPassword(password); | ||
| // return xaDataSource; |
There was a problem hiding this comment.
can we remove commented out code and a WEB reference.
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.alfasoftware.morf.jdbc.h2; |
There was a problem hiding this comment.
should packaging be h2v2 for clarity?
| /** | ||
| * Tests for DatabaseType.H2 | ||
| * | ||
| * @author Copyright (c) Alfa Financial Software 2014 |
There was a problem hiding this comment.
copyright dates should be 2026
| <title>Package details</title> | ||
| </head> | ||
| <body> | ||
| <p>Implementations specific to H2 databases.</p> |
There was a problem hiding this comment.
specific to H2 version 2.
And indicate that morf-h2 is specific to H2 version 1.
| @@ -0,0 +1 @@ | |||
| /ivy.xml | |||
There was a problem hiding this comment.
not really relevant anymore
| </parent> | ||
|
|
||
| <name>Morf - H2 version 2</name> | ||
| <description>Morf is a library for cross-platform evolutionary relational database mechanics, database access and database imaging/cloning.</description> |
There was a problem hiding this comment.
I think that these descriptions should contain something specific to the sub-project (though I recognise currently none of the others do)
| <dependency> | ||
| <groupId>com.h2database</groupId> | ||
| <artifactId>h2</artifactId> | ||
| <version>2.3.232</version> |
There was a problem hiding this comment.
Can we use the latest version 2.4.240?
Looks to have a number of fixes: https://github.com/h2database/h2database/releases/tag/version-2.4.240
4 participants
Add support for H2 version 2 in morf-h2v2 module.