feat(bernese): stage GEN/SESSIONS.SES in prepare_campaign (RH-003) - #39
Merged
alfieprojectsdev merged 3 commits intoJul 2, 2026
Merged
Conversation
_SUBDIRS omitted GEN and no session table was generated, so BPE aborted early — the exact stall hit during the NAMRIA training week. Closes readiness gap #2. - Add GEN to _SUBDIRS. - campaign_builder: generate_sessions_ses() returns the stock daily '???0' session table (whole UTC day, verbatim from $X/SUPGUI/PAN/SESSIONS.SES); stage_sessions_ses() writes it into campaign GEN/, copying an explicit install template when given and never clobbering a hand-tuned existing SESSIONS.SES. - prepare_campaign() writes SESSIONS.SES unconditionally (independent of CampaignConfig) since BPE needs it regardless; new sessions_template= arg. - test_campaign_builder.py +5. 80 pass, ruff clean. Developed in worktree .trees/rh-003-gen-sessions off branch feat/rh-003-gen-sessions.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alfieprojectsdev
added a commit
that referenced
this pull request
Jul 1, 2026
# Conflicts: # docs/project_documentation/ticket_backlog.md
…o feat/rh-003-gen-sessions # Conflicts: # services/bernese-workflow/src/bernese_workflow/backends.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RH-003 —
prepare_campaign()stages GEN/SESSIONS.SES (readiness gap #2)Stacked on #38 (branched off
docs/bernese-training-notes); base retargets tomainonce #38 merges.Problem
_SUBDIRSomittedGEN, andprepare_campaign()generated no session table. BPE readsGEN/SESSIONS.SESto map a processed session id to its epoch window — without it the run aborts early. This is the exact stall hit during the NAMRIA training week (had to be created by hand).Change
GENto_SUBDIRS.campaign_builder.generate_sessions_ses()returns the stock daily???0session table (one session, whole UTC day00:00:00–23:59:59) — verbatim from$X/SUPGUI/PAN/SESSIONS.SESand every campaignGEN/SESSIONS.SESon the verified T420 install.stage_sessions_ses(gen_dir, template=None)writes it into the campaignGEN/. Copies an explicit install template when given (exact match to the installed Bernese version); never clobbers a pre-existing hand-tuned SESSIONS.SES.prepare_campaign()writes SESSIONS.SES unconditionally — independent ofCampaignConfig, since BPE needs it regardless of whether station files are generated. Newsessions_template=passthrough arg.Tests
test_campaign_builder.py+5 (daily-template content,GENin_SUBDIRS, no-config write, template copy, preserve-existing). 80 pass, ruff clean. (mypy: one pre-existingrequestsimport-stub note indownload_blq, unrelated to this change.)Scope note
Other
GEN/general files (ANTENNA_I20.PCV,OBSERV.SEL,SINEX_RNX2SNX.SKL) are also needed for a full run but are separate reference-file staging — out of scope here.Workflow
First ticket developed under the new git-worktree protocol (
.trees/rh-003-gen-sessions), and opened viascripts/open_pr.sh(also added in #38).