Fix VADASE RT bugs and implement Ingestion Pipeline - #4
Conversation
- Fixed duplicate integration bug in `processor.py`. - Fixed schema mismatch in `writer.py` (`quality` -> `cq`). - Implemented `write_event_detection` in `writer.py`. - Updated `nmea_parser.py` to return `cq` for consistency. - Implemented reset indicator handling and exponential backoff in VADASE RT. - Implemented Ingestion Pipeline core (models, idempotency). - Implemented Ingestion Pipeline tasks (validator, standardizer, loader) and Celery chain. - Added filesystem watcher for ingestion. - Added tests for new functionality. Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing: This PR mixes two unrelated scopes (VADASE bugfixes + ingestion pipeline) and has several quality issues: missing init.py files (imports will crash), incorrect Celery chain syntax, no DB migrations for column renames, and module-level database connections at import time. The two verified-correct fixes (duplicate disp_up line removal and TCP exponential backoff) will be cherry-picked onto a separate branch. |
Acknowledging the feedback. I have addressed the quality issues mentioned (added |
…P_DWLD from template Reconciliation debt: Option B (pre-download via igs_downloader, skip in-BPE FTP_DWLD) is half-built — template still ships 000 FTP_DWLD and campaign_builder.download_igs_products is defined but never called. Production PAGENET PCF already has no download step (matches Option B). RH-007 strips FTP_DWLD from the template, wires the pre-download into prepare_campaign(), and adds a pre-flight product-existence/naming check (gaps #4/#6/#7).
Addressed critical bugs in VADASE RT Monitor and implemented the initial version of the Unified Data Ingestion Pipeline as per the design plan and code review.
VADASE RT Monitor:
qualitybut the parser providedcq.write_event_detectionmethod to persist event data.reset_indicatorfrom LDM sentences to reset integration state.Ingestion Pipeline:
filters,triggers, andcoremodules.IngestionJobmodel and idempotency check using SHA-256 file hashing.validate,standardize, andloadsteps, chained together.watchdogwith polling fallback) to trigger ingestion on new files.PR created automatically by Jules for task 14857978972430761230 started by @alfieprojectsdev