Skip to content

Fix VADASE RT bugs and implement Ingestion Pipeline - #4

Closed
alfieprojectsdev wants to merge 1 commit into
mainfrom
jules/vadase-ingestion-fix-14857978972430761230
Closed

Fix VADASE RT bugs and implement Ingestion Pipeline#4
alfieprojectsdev wants to merge 1 commit into
mainfrom
jules/vadase-ingestion-fix-14857978972430761230

Conversation

@alfieprojectsdev

Copy link
Copy Markdown
Owner

Addressed critical bugs in VADASE RT Monitor and implemented the initial version of the Unified Data Ingestion Pipeline as per the design plan and code review.

VADASE RT Monitor:

  • Fixed a critical bug where vertical displacement was integrated twice.
  • Fixed a schema mismatch where the database writer expected quality but the parser provided cq.
  • Implemented the missing write_event_detection method to persist event data.
  • Added logic to handle reset_indicator from LDM sentences to reset integration state.
  • Implemented exponential backoff for TCP reconnection to improve stability.

Ingestion Pipeline:

  • Created the service structure with filters, triggers, and core modules.
  • Implemented IngestionJob model and idempotency check using SHA-256 file hashing.
  • Implemented Celery tasks for validate, standardize, and load steps, chained together.
  • Added a filesystem watcher (watchdog with polling fallback) to trigger ingestion on new files.
  • Added unit tests for validation logic.

PR created automatically by Jules for task 14857978972430761230 started by @alfieprojectsdev

- Fixed duplicate integration bug in `processor.py`.
- Fixed schema mismatch in `writer.py` (`quality` -> `cq`).
- Implemented `write_event_detection` in `writer.py`.
- Updated `nmea_parser.py` to return `cq` for consistency.
- Implemented reset indicator handling and exponential backoff in VADASE RT.
- Implemented Ingestion Pipeline core (models, idempotency).
- Implemented Ingestion Pipeline tasks (validator, standardizer, loader) and Celery chain.
- Added filesystem watcher for ingestion.
- Added tests for new functionality.

Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@alfieprojectsdev

Copy link
Copy Markdown
Owner Author

Closing: This PR mixes two unrelated scopes (VADASE bugfixes + ingestion pipeline) and has several quality issues: missing init.py files (imports will crash), incorrect Celery chain syntax, no DB migrations for column renames, and module-level database connections at import time.

The two verified-correct fixes (duplicate disp_up line removal and TCP exponential backoff) will be cherry-picked onto a separate branch.

@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing: This PR mixes two unrelated scopes (VADASE bugfixes + ingestion pipeline) and has several quality issues: missing init.py files (imports will crash), incorrect Celery chain syntax, no DB migrations for column renames, and module-level database connections at import time.

The two verified-correct fixes (duplicate disp_up line removal and TCP exponential backoff) will be cherry-picked onto a separate branch.

Acknowledging the feedback. I have addressed the quality issues mentioned (added __init__.py, fixed Celery chain syntax, lazy DB connection) in this PR for completeness, although I understand if you prefer to cherry-pick the VADASE fixes separately. Regarding the DB migrations, the init_database.sql script already defines the cq column, so I updated the code to match the existing schema rather than renaming the column in the DB.

alfieprojectsdev added a commit that referenced this pull request Jul 1, 2026
…P_DWLD from template

Reconciliation debt: Option B (pre-download via igs_downloader, skip in-BPE FTP_DWLD)
is half-built — template still ships 000 FTP_DWLD and campaign_builder.download_igs_products
is defined but never called. Production PAGENET PCF already has no download step (matches
Option B). RH-007 strips FTP_DWLD from the template, wires the pre-download into
prepare_campaign(), and adds a pre-flight product-existence/naming check (gaps #4/#6/#7).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant