🧹 Code Health: Remove commented import in bootstrap_v2.py - #8
🧹 Code Health: Remove commented import in bootstrap_v2.py#8alfieprojectsdev wants to merge 1 commit into
Conversation
Removed the unused `#import matlab` line from `analysis/08 Bootstrapping/bootstrap_v2.py`. This improves code cleanliness by removing clutter. Note: The file contains hardcoded paths and `import matlab.engine` which are retained as they are functional (though platform specific). Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…-153735260210762914 Verified: ~150 lines of duplicated bootstrap code consolidated. Fixes deprecated df.append() for pandas 2.0+ compatibility. Supersedes PR #8.
|
Closing: Superseded by PR #14 which also touches bootstrap_v2.py with a more comprehensive refactor (removes ~150 lines of duplication + fixes deprecated df.append). |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
…rence set Abegail (Luzon network) delivered a 22 GB Bernese 5.2 processed set on the DOSTB drive for the 5.2-vs-5.4 comparison. The configuration half is captured here; the data half stays on the drive (PROVENANCE.md §5 inventories it). This is the production workflow of record, not a training example: GPSTEMP holds 1,203 BPE_PHIVOL_REL_* work directories, and PHIVOL_REL.PCF is dated 2025-09-12. It answers two open questions. Session log §14.5 suspected PAGENET_DLY.PCF might be an unsafe by-eye truncation leaving 599 DUMMY waiting on an undefined 522. It is not. PAGENET_DLY (46 PIDs) is a deliberate reduction of this lineage (84 PIDs), with 521/522 removed and 599 rewired to compensate. PAGENET.PCF (2015) and PAGENET2.PCF (2019) are also captured, so the whole lineage is now in the repo. Readiness item M -- decide Module 15/16 scope before building weekly/monthly plumbing -- has a reference implementation: 530 ADD_WK / PHI_WK and 531 ADD_MON / PHI_MO, plus the 901/902/903/991 save-summarise-clean tail that PAGENET_DLY lacks entirely. Operator names scrubbed. Bernese panels carry a free-text "USER" field naming whoever last saved the panel; this tree held four staff names and workstation accounts across 72 files, all now "<operator>". This repo is public and a colleague's name published without her knowing is not something a capture is entitled to do. The field is menu metadata and does not affect processing. Everything else is byte-for-byte, minus 44 *.bck editor backups. Two cautions, both in PROVENANCE.md: - Six LIVE .INP panels (not backups) carry C:\Bernese\... absolute paths -- gap #8, and on Linux a backslash is a literal character, so these resolve to filenames containing backslashes rather than failing loudly. Point provision_gpsuser.py at this tree before any use. The ENVIRONMENT block needs more than separator conversion; U and T are another machine's layout. - The two sets do NOT share models. 5.2 LUZON uses I14 and V_GNSSAR=ALL; 5.4 PAGENET uses I20 and GRE. Baselines and V_CLU agree. I14->I20 is a cm-level mostly-vertical systematic shift, well inside the range a tuning change could produce -- so reproduce her numbers under I14 first, then vary the model deliberately. Otherwise the frame change lands in the results looking like a PCF improvement. Also note the OPT tree is not uniformly a LUZON set: of the live panels, 38 name campaign ${P}/PHIVOLCS, 9 LUZON, 2 SAMR_LYT, 1 EXAMPLE. These are last-saved menu states from different work, not a curated gold standard. Mostly cosmetic since the BPE sets the campaign at runtime, but the directory name overstates what is in it. Version and run method needed no asking: BERN52 carries update_2020-08-27.zip and exe_aiub_64_2021.zip, and the BPE work directories settle GUI-vs-BPE. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 participant
Removed commented import
#import matlabfromanalysis/08 Bootstrapping/bootstrap_v2.pyas part of code health improvement. Verified that no active code was removed.PR created automatically by Jules for task 21455644552887745 started by @alfieprojectsdev