🔒 Fix command injection in campaign_v6.py - #9
Conversation
Replaced unsafe `os.system` call with `subprocess.run` to prevent command injection via user-supplied input. Arguments are now passed as a list to ensure proper handling of special characters and avoid shell interpretation. Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing: Only fixes 1 of 2 os.system calls in this local research script. The second (line 20, runpkr00) is left unfixed. Additionally, this is a standalone analysis script where the 'attacker' is the person running it — there is no privilege escalation vector. Low priority. |
Thank you for the review. I have now also replaced the |
This PR fixes a critical command injection vulnerability in
analysis/01 RINEX conversion/campaign_v6.py.The
os.systemfunction was used to executeteqcwith user-provided arguments (mo,at,pe,teqc), allowing an attacker to inject arbitrary commands.This change replaces
os.systemwithsubprocess.runusing a list of arguments, which prevents the shell from interpreting the arguments as commands.Verified by creating a reproduction script to confirm the vulnerability and a verification script to ensure the fix correctly handles the inputs without injection.
PR created automatically by Jules for task 15765682862018274902 started by @alfieprojectsdev