Skip to content

fix(telemetry): identify only after login/signup - #277

Merged
LorrisSaintGenez merged 6 commits into
mainfrom
fix/telemetry-identify-login-only
Aug 3, 2026
Merged

fix(telemetry): identify only after login/signup#277
LorrisSaintGenez merged 6 commits into
mainfrom
fix/telemetry-identify-login-only

Conversation

@LorrisSaintGenez

@LorrisSaintGenez LorrisSaintGenez commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

What

  • Remove the per-command Identify from PersistentPreRunE: a single Identify is now emitted at command completion when the run established or renewed the session (login, signup, account switch, re-authentication, silent token refresh)
  • Carry version, operating_system, configured_applications and is_ci as non-overridable base props on every Track event, so per-event analytics keep working now that traits refresh only on session changes

Test

task build
DEBUG=1 ./algolia describe 2>&1 | grep -c '{identify'   # 0, even when logged in
DEBUG=1 ./algolia describe 2>&1 | grep '{track'         # props include version, operating_system, configured_applications, is_ci

Login path still identifies: DEBUG=1 ./algolia auth login → one {identify line at the end of the run. (ALGOLIA_CLI_TELEMETRY must be unset; source builds land in the dev Segment source https://app.segment.com/algolia-app/sources/segment_cli_dev/debugger)

@LorrisSaintGenez LorrisSaintGenez self-assigned this Jul 30, 2026
@LorrisSaintGenez
LorrisSaintGenez marked this pull request as ready for review July 30, 2026 22:08
@LorrisSaintGenez
LorrisSaintGenez marked this pull request as draft July 30, 2026 22:09
@LorrisSaintGenez
LorrisSaintGenez marked this pull request as ready for review July 30, 2026 22:11
@codacy-production

codacy-production Bot commented Jul 30, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 14 duplication

Metric Results
Complexity 0
Duplication 14

View in Codacy

TIP This summary will be updated as you push new changes.

@LorrisSaintGenez
LorrisSaintGenez merged commit 286ce2d into main Aug 3, 2026
3 checks passed
@LorrisSaintGenez
LorrisSaintGenez deleted the fix/telemetry-identify-login-only branch August 3, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants