This repository was archived by the owner on Dec 16, 2022. It is now read-only.
feat(templates): Use searchClient in Angular
#114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version was not compatible with Angular.
samouss
reviewed
Jul 9, 2018
| appId: '{{appId}}', | ||
| apiKey: '{{apiKey}}', | ||
| indexName: '{{indexName}}', | ||
| searchClient: algoliasearch('{{appId}}', '{{apiKey}}'), |
Contributor
There was a problem hiding this comment.
How do we handle versions that does not support searchClient (v1.x.x)?
Contributor
Author
There was a problem hiding this comment.
We already don't because the components have been renamed in 2.x.x (we dropped ng-).
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related