This repository was archived by the owner on Dec 16, 2022. It is now read-only.
feat(cli): Print relative cd path #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
approved these changes
Jun 12, 2018
Contributor
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
Did none of the tests change?
Contributor
Author
|
Regarding the cd path? We can test it although I'm not sure it's that relevant. However, I admit I need to test the CLI part way more (the |
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
If generating the app `my-app-4` from `/tmp/apps`, recommend to change directory to: - Before: `/tmp/apps/my-app-4` - After: `my-app-4`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If generating the app
my-app-4from/tmp/apps, recommend to change directory to:/tmp/apps/my-app-4my-app-4