This repository was archived by the owner on Dec 16, 2022. It is now read-only.
fix(templates): add packageNamePrefix to widget templates
#458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
requested review from
a team,
Haroenv,
francoischalifour and
tkrugg
and removed request for
a team
Haroenv
approved these changes
Jun 24, 2021
Co-authored-by: Haroen Viaene <hello@haroen.me>
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
…create-instantsearch-app#458) Co-authored-by: Haroen Viaene <hello@haroen.me>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
packageNamePrefixto the widget templates.For example, when the project name is
test, it becomes like this:@user-scope/instantsearch-widget-test@user-scope/react-instantsearch-widget-testNote
appNameconfig in the widget templates are actually almost useless, becausepackageNameis used instead. It's only used in snapshot tests.To make the snapshots more readable/meaningful, I changed the value of
appNamefor both InstantSearch.js widget and React InstantSearch widget and thus, the snapshots have change quite a lot in this PR.