feat: Modal UI/UX fixes and updates #2780
Merged
+32
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8bittitan
requested review from
NatanTechofNY,
dylantientcheu,
pipeline1987,
shortcuts and
vascobettencourt
as code owners
✅ Deploy Preview for docsearch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pipeline1987
approved these changes
Oct 3, 2025
Contributor
|
should fix this: #2173 |
slorber
reviewed
Jan 21, 2026
| export function Results<TItem extends StoredDocSearchHit>(props: ResultsProps<TItem>): JSX.Element | null { | ||
| // The collection title, decoded to handle encoded HTML entities | ||
| const decodedTitle = React.useMemo(() => { | ||
| return props.title |
Contributor
There was a problem hiding this comment.
Hi @8bittitan , we have a Docusaurus user (@martindekov) reporting an error on this line due to props.title being undefined
Website: https://docs.harvesterhci.io/
Source: https://github.com/harvester/docs
Reported here: facebook/docusaurus#11664 (reply in thread)
I don't know if an undefined title is expected (maybe an index/crawler misconfig?), but their site worked before the upgrade, so maybe it's worth adding optional chaining or something to be safe?
This was referenced Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
• Improves modal responsiveness by introducing dynamic viewport height for the dropdown container while maintaining the existing max-height constraint
• Fixes issue where starting a new conversation wasn't properly clearing previous messages by moving the message clearing logic to the question selection handler
• Refines typography and spacing across the Ask AI interface for better readability (adjusted font sizes, line heights, and margins)
• Fixes HTML entity encoding in collection titles by properly decoding them before display
Previews