Consider the key's lowercase form while grouping

[redox]

Fix #85

[algobot]

By analyzing the blame information on this pull request, we identified @pixelastic to be a potential reviewer

[redox]

@pixelastic What do you think about that?

[coveralls]

Coverage remained the same at 99.206% when pulling b45c603 on fix/85 into dd596e4 on develop.

[pixelastic]

Why the &&?

let key = item[property].toLowerCase(); should be enough

[maxiloc]

I think playground was failing otherwise

[redox]

Because item[property] can be null

[pixelastic]

Then we should update the if a few line above, where it is testing if it's undefined to also test null

[redox]

Hmmm, I think it's fine to group hits sharing the null value together. It happens if - for a unknown reason - you don't have lvl1 for instance.

I can make the test more explicit if you want.

[pixelastic]

I would make the code more explicit then.

let key = item[property];
if (key.toLowerCase) {
  let = key.toLowerCase();
}

Still not perfect (key can be an object with a toLowerCase field that is not a function...) but it expresses the intent of what you want to do more easily.

[coveralls]

Coverage remained the same at 99.206% when pulling adc0ab9 on fix/85 into dd596e4 on develop.

[coveralls]

Coverage increased (+0.01%) to 99.219% when pulling e4705b3 on fix/85 into dd596e4 on develop.