Skip to content

add clojure implementation for bogo sort#38

Merged
leios merged 10 commits intoalgorithm-archivists:masterfrom
earthfail:master
Feb 8, 2018
Merged

add clojure implementation for bogo sort#38
leios merged 10 commits intoalgorithm-archivists:masterfrom
earthfail:master

Conversation

@earthfail
Copy link
Contributor

I'm starting with the simple stuff

again Mr. @leios if there is anything you want me to contribute tell me. I want this project to succeed

@june128
Copy link
Member

june128 commented Feb 6, 2018

Hey @earthfail I'am currently adding Clojure to the book.json. So @leios please hold the PR for a second :)

@leios
Copy link
Member

leios commented Feb 6, 2018

Not a problem! I was trying to figure out how to get the syntax highlighting to work. It looks like clojure is another C/C++ right now without highlighting? I need to figure out how to fix that...

@june128
Copy link
Member

june128 commented Feb 6, 2018

@leios I'll look into that

@earthfail
Copy link
Contributor Author

thanks, @julianschacherpp I thought there was something wrong with my browser
👍

@june128
Copy link
Member

june128 commented Feb 6, 2018

Ok, I have updated a few things and want to help you (and everyone reading this) by explaining my changes.


I added this to the book.json:

{
	"lang": "clj",
	"name": "Clojure"
}

This basically says, that you can use clj for Clojure in the chapters like this:

{% sample lang="clj" %} // here you can use clj instead of clojure
### Clojure
[import:1-, unindent:"true", lang="clojure"](code/clojure/euclidean_example.clj)

That displays the following at the top of the page (because of the book.json):
clojure_example_book json_aaa_screen shot 2018-02-06 at 22 31 38_edit


I also brought the code at the bottom of euclidean.md in order, because you mixed it up a bit. It's quite confusing, because of the prominent heading not being at the start of the implementation of the language. So here's the order of the code lines you have to write:

{% sample lang="clj" %} // First we say that the clj (Clojure) part is know starting.
### Clojure // Displaying the heading before the code.
[import:1-, unindent:"true", lang="clojure"](code/clojure/euclidean_example.clj) // Importing the code.

I posted a pull request for your master branch on your repo, which implements those changes. (https://github.com/earthfail/algorithm-archive/pull/1) So I hoped my comments helped you understand, what I did and why. If you have any questions, feel free to ask me :)

@leios
Copy link
Member

leios commented Feb 8, 2018

Hey @earthfail ,

My understanding is that @julianschacherpp had a few smallscale changes and created a pull request for your fork. Once those changes are merged, I'll merge here.

Sorry for any confusion / if my understanding is incorrect!

Thanks again! =)

Add clojure to book.json and update implemented chapters.
@leios leios merged commit ac7b257 into algorithm-archivists:master Feb 8, 2018
@leios
Copy link
Member

leios commented Feb 8, 2018

Hey @earthfail thanks for the submission!

@julianschacherpp, thanks for the help! =)

@earthfail
Copy link
Contributor Author

yeah @julianschacherpp you're the real mvp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants