Skip to content

feat: surface server icon and website URL in MCP serverInfo (SEP-973) - #87

Merged
aliasunder merged 3 commits into
mainfrom
claude/vault-bootstrap-setup-5z5j02
Jun 10, 2026
Merged

feat: surface server icon and website URL in MCP serverInfo (SEP-973)#87
aliasunder merged 3 commits into
mainfrom
claude/vault-bootstrap-setup-5z5j02

Conversation

@aliasunder

@aliasunder aliasunder commented Jun 10, 2026

Copy link
Copy Markdown
Owner

Summary

Adds icons and websiteUrl to the Implementation metadata returned during initialize (MCP spec 2025-11-25, SEP-973). Clients that support server icons render the project mark beside the connection instead of a generic or domain-derived favicon.

Why

MCP clients that don't implement SEP-973 fall back to deriving a connection icon from the server URL's domain — for an API Gateway deployment that resolves to the AWS favicon rather than anything project-related. Publishing the icon in serverInfo is the spec-correct, domain-independent fix: compliant clients pick it up immediately, and clients that currently ignore the field (tracked upstream in anthropics/claude-ai-mcp#152) inherit it the moment they add support, with no further server change.

Changes

  • src/vault-mcp/mcp-router.tsSERVER_ICONS (the existing assets/icon-400.png, referenced via its raw GitHub URL so it stays valid regardless of deployment domain) and SERVER_WEBSITE_URL constants, passed to the McpServer constructor alongside the existing name/title/version/description.
  • src/vault-mcp/__tests__/mcp-router.test.tsSERVER_INFO expectation extended to the new fields (exact-match assertion; fails if the metadata is removed).

Verification

  • 520/520 tests pass; tsc and eslint clean.
  • Mutation-audited: reverting the source change fails exactly the serverInfo metadata test.
  • Field support verified against the pinned @modelcontextprotocol/sdk 1.29.0 ImplementationSchema (icons, websiteUrl both present).

Generated with Claude Code


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Added icons array and website URL metadata to MCP server configuration in both test and production implementations.

Add icons and websiteUrl to the Implementation metadata returned during
initialize (MCP spec 2025-11-25). Clients that support SEP-973 render
the project icon beside the connection instead of a generic or
domain-derived favicon. The icon is served from the repo's raw GitHub
URL so it stays valid regardless of deployment domain.

Generated with Claude Code

Co-authored-by: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@aliasunder, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 13 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1913fc3c-3d16-41c5-81cb-ae50162468a4

📥 Commits

Reviewing files that changed from the base of the PR and between f8ecaef and 46a0731.

📒 Files selected for processing (2)
  • src/vault-mcp/__tests__/mcp-router.test.ts
  • src/vault-mcp/mcp-router.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/vault-bootstrap-setup-5z5j02

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aliasunder
aliasunder merged commit bddec20 into main Jun 10, 2026
5 checks passed
@aliasunder
aliasunder deleted the claude/vault-bootstrap-setup-5z5j02 branch June 10, 2026 15:23
aliasunder added a commit that referenced this pull request Sep 5, 2026
## Summary

Bump umm-actually from v0.3.14 to v0.4.0 (`65ccbe7`).

### Changes in v0.4.0

- feat: staged review phases — parallel and sequential modes (\#79)
- feat: content-based cross-run dedup for shifted/reworded findings
(\#85)
- fix: content dedup follow-ups — coalesceAnchors, titleSimilarity,
logging (\#86)
- fix: filter self-negating findings (\#84)
- chore: bump default context_budget_tokens from 80K to 300K (\#87)
- docs: drop the early-development status section (\#83)
aliasunder added a commit that referenced this pull request Sep 5, 2026
…535)

The v0.4.0 bump PR was merged with the old `'80000'` fallback. This
aligns it with the action's new 300K default (umm-actually PR #87).

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants