[Core:Bugfix] Fix crashes when mmap allocation fails across all backends - #4630
Merged
Conversation
When mmap-backed allocation fails (disk full, mmap error, file too short), backends silently stored null device pointers into tensors, causing EXC_BAD_ACCESS / SIGBUS crashes on iOS. Fixes across all backends: - LLM: grow mmap cache file before mmap to avoid SIGBUS past EOF; release module before runtime in load() to fix use-after-free - Metal: check nil Metal buffer from failed mmap, fall back to non-mmap GPU allocator (mStaticAllocatorRaw) - OpenCL: null-check all alloc() paths in onAcquire, fall back to non-mmap BufferPool; propagate MmapPool failure instead of wrapping null - CPU: fall back to mStaticAllocatorRaw when mmap static allocation fails - Vulkan: fix CALL_VK no-op in release builds; null-check allocations in onAcquire, VulkanBuffer/VulkanImage constructors - CUDA: add null checks after pool->alloc() in all 26 execution kernels, return OUT_OF_MEMORY or set mValid=false Discussed-in: Merge-Request 28543428 , URL: https://code.alibaba-inc.com/AliNN/AliNNPrivate/codereview/28543428 GitOrigin-RevId: b59217536d041370f22167289464ad7225a14178
|
jingbang.yjb seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
wangzhaode
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mmap-backed allocation fails (disk full, mmap error, file too short), backends silently stored null device pointers into tensors, causing EXC_BAD_ACCESS / SIGBUS crashes on iOS.
Fixes across all backends:
Discussed-in: Merge-Request 28543428 , URL: https://code.alibaba-inc.com/AliNN/AliNNPrivate/codereview/28543428
GitOrigin-RevId: b59217536d041370f22167289464ad7225a14178
Description
Module
Type
Checklist
[Module:Type] Descriptionformat