Skip to content

Fixes #474 DiffEditorDialog, ConfigEditor #508

Merged
loadchange merged 1 commit into
alibaba:developfrom
loadchange:issues-474-DiffEditorDialog
Dec 24, 2018
Merged

Fixes #474 DiffEditorDialog, ConfigEditor #508
loadchange merged 1 commit into
alibaba:developfrom
loadchange:issues-474-DiffEditorDialog

Conversation

@loadchange

Copy link
Copy Markdown
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

  • DiffEditorDialog
  • ConfigEditor

Brief changelog

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@loadchange loadchange merged commit a2d6eac into alibaba:develop Dec 24, 2018
@loadchange loadchange deleted the issues-474-DiffEditorDialog branch December 28, 2018 08:51
KiteSoar pushed a commit to KiteSoar/nacos that referenced this pull request Mar 1, 2025
* feat: 🎸 fix link

* fix: 🐛 fix descriptioin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant