feat: Optimize PK MOR read performance by reduce per-row object allocation and improve merge read performance. - #356
Merged
Conversation
dalingmeng
force-pushed
the
pk-mor-read-opt
branch
from
June 10, 2026 08:34
74e12f8 to
e7a1ec0
Compare
lucasfang
reviewed
Jun 10, 2026
dalingmeng
force-pushed
the
pk-mor-read-opt
branch
2 times, most recently
from
June 11, 2026 03:21
8f5f33f to
089c7b1
Compare
…ation and improve merge read performance.
dalingmeng
force-pushed
the
pk-mor-read-opt
branch
from
June 11, 2026 10:02
d01f216 to
8b44a7f
Compare
lxy-9602
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #321
Optimize PK MOR read performance by reducing per-row overhead in the merge-on-read path.
This change improves the key-value data file reader and merge functions to avoid unnecessary
object allocation and repeated checks during row iteration. It also adds a fast path when all rows
in a batch are selected, reducing bitmap lookup overhead in common scan scenarios.
Tests
GenericRowTest.TestResetFields
API and Format
Documentation
Generative AI tooling
Generated-by: Aone Copilot, ide-idealab/claude4.6-opus