fix: file-related error messages on Windows#341
Merged
feihongxu0824 merged 1 commit intoalibaba:mainfrom Apr 16, 2026
Merged
Conversation
JalinWang
requested review from
chinaux,
iaojnh,
richyreachy and
zhourrr
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
JalinWang
force-pushed
the
fix/file_op_error_msg_on_windows
branch
from
315acf7 to
b738cd9
Compare
JalinWang
changed the title
feihongxu0824
approved these changes
Apr 16, 2026
iaojnh
pushed a commit
to iaojnh/zvec
that referenced
this pull request
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a file-related error occurs on Linux, we use strerror(errno) to get the error message, but this does not work on Windows. This change makes the behavior platform-adaptive.
Follow-up to #333.