fix(kmeans): correct spherical centroid normalization - #654
Merged
Conversation
egolearner
force-pushed
the
fix/spherical_kmeans
branch
from
August 5, 2026 03:10
e6d3f9e to
605fe74
Compare
iaojnh
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix spherical K-means behavior for floating-point vectors by ensuring that
centroids are L2-normalized after each Lloyd iteration
Motivation
The previous
Norm2overloads selected the non-normalizing fallback forfloating-point contexts, leaving spherical centroids unnormalized.