fix: retry hosted compute updates after failed apply - #531
Merged
Conversation
Greptile SummaryThe PR changes hosted compute updates so equal persisted targets are resubmitted while a deployment is in any supported non-running lifecycle state, allowing interrupted applies to be retried while preserving the equality fast path for running deployments.
Confidence Score: 5/5The PR appears safe to merge with no concrete correctness or security issues identified. The new predicate preserves changed-compute updates for running deployments and resubmits equal targets only for lifecycle states already admitted by the existing hosted-compute status guard.
|
| Filename | Overview |
|---|---|
| crates/alien-deploy-cli/src/commands/up.rs | Broadens hosted compute submission only within the existing supported-status gate and adds tests for running, in-flight, and failed lifecycle states. |
Reviews (1): Last reviewed commit: "fix: retry hosted compute updates after ..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Platform persists desired settings before the deployment engine applies them. After a failed apply, the desired target may already match the caller while the cloud still has the previous capacity. Re-submitting the target lets Platform’s idempotent operation queue repair the incomplete update.