[Aikido] Fix security issue in yargs via major version upgrade from 17.7.2 to 18.1.0 - #1743
Merged
AdamJHall merged 2 commits intoJul 31, 2026
Merged
Conversation
AdamJHall
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade yargs to fix prototype pollution vulnerability in configuration merging that could allow attackers to manipulate object prototypes through malicious config inputs.
✅ Code not affected by breaking changes.
✅ No breaking changes affect this codebase. The package
yargsis not directly used in the project - it only appears as a transitive dependency throughjest-cliandnx. There are no imports, requires, or usage of yargs APIs in any source files. The breaking changes related to command names, singleton usage, Node.js version requirements, and ESM-first approach do not impact this codebase.All breaking changes by upgrading yargs from version 17.7.2 to 18.1.0 (CHANGELOG)
command.^20.19.0 || ^22.12.0 || >=23.✅ 1 CVE resolved by this upgrade
This PR will resolve the following CVEs:
__proto__keys, potentially enabling arbitrary property manipulation and code execution.🤖 Remediation details
Fix transitive
yargsvulnerability viaresolutionsoverrideShort summary
This PR fixes a vulnerability in the transitive dependency
yargs(versions< 18.1.0), which was being resolved at17.7.2across the workspace. The fix is applied in the rootpackage.json(via aresolutionsentry) and the correspondingyarn.lockwas refreshed to reflect the new resolved version.yargs
yargs@17.7.2was pulled in transitively by two parents:jest-cli@29.7.0(declaring^17.3.1) andnx@20.8.4(declaring^17.6.2). A full parent-chain analysis confirmed that no published version of any ancestor — including the latest releases ofjest-cli,nx, and all@nx/*packages — ever declares ayargsrange that admits>= 18.1.0; the latestnxcanary still pinsyargsat exactly17.7.2. Because no parent bump can deliver the patched version, aresolutionsentry of"yargs": "^18.1.0"was added to the rootpackage.json, and the lockfile was refreshed withyarn install --mode=update-lockfile, resolvingyargsto18.1.0. Several new packages (cliui,string-width,ansi-styles, etc.) were added to the lockfile as updated dependencies ofyargs@18.x, andrequire-directory(ayargs@17.x-only dependency) was removed.Version changes
yargs17.7.218.1.0resolutionsoverridecliui9.0.1yargs@18.xstring-width7.2.0yargs@18.xansi-styles6.2.3yargs@18.xansi-regex6.2.2yargs@18.xemoji-regex10.6.0yargs@18.xget-east-asian-width1.6.0yargs@18.xrequire-directory2.1.1yargs@18.x