fix: report per-context session id in a2a/acp telemetry#23
Merged
Conversation
Telemetry's get_session_id() returned the process-level bootstrap id (iac_sess_a2a-server-<uuid>), so every A2A context and ACP session in one server process shared the same gen_ai.session.id in spans and the same name in fallback batches — multiple conversations looked like one session. Add a contextvar-backed override in Identity plus a use_session_id() context manager, and wrap each run_streaming call in a2a/acp with the per-conversation session id. Process-level resource session.id stays the bootstrap value; headless/REPL paths are unaffected. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telemetry's get_session_id() returned the process-level bootstrap id (iac_sess_a2a-server-), so every A2A context and ACP session in one server process shared the same gen_ai.session.id in spans and the same name in fallback batches — multiple conversations looked like one session.
Add a contextvar-backed override in Identity plus a use_session_id() context manager, and wrap each run_streaming call in a2a/acp with the per-conversation session id. Process-level resource session.id stays the bootstrap value; headless/REPL paths are unaffected.