Conversation
Contributor
Author
|
btw: we will need to switch to allaboutapps/nullable again before merging this of course. allaboutapps/nullable#2 comes first. |
MorpheusXAUT
approved these changes
Mar 8, 2021
MorpheusXAUT
left a comment
MorpheusXAUT
left a comment
There was a problem hiding this comment.
I'd say the actual bind testing (as added here) should be good enough and can continue to live in the nullable package itself - copying it to here seems a bit redundant, especially since you might potentially not even use any of the nullable types.
LGTM (given the package-change once the other PR is merged), thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In context to allaboutapps/nullable#2 - make it easier for us to catch generation problems earlier with nullable after upgrades to goswagger.
No sure if we should add dedicated binding testing from this to go-starter, feels like this should continue to live in allaboutapps/nullable.