Mr/contextvalidate#2
Merged
majodev merged 6 commits intoallaboutapps:masterfrom Mar 8, 2021
Merged
Conversation
…types, add tests for interfaces compability
This was referenced Feb 26, 2021
mwieser
approved these changes
Mar 4, 2021
MorpheusXAUT
reviewed
Mar 8, 2021
| "github.com/go-openapi/runtime" | ||
| ) | ||
|
|
||
| func TestInt16ImplementsRuntimeValidatable(t *testing.T) { |
There was a problem hiding this comment.
We could potentially also resort to the way e.g. the pq Postgres driver ensures the types implement the sql.Driver interface properly: https://github.com/lib/pq/blob/master/conn.go#L42
Could be added to each one of the generated files instead of having a runtime test for extra "security".
Author
There was a problem hiding this comment.
agreed, rm'ed + added in each generated file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contextvalidate support + interface testing with openapi runtime