Fix trailing commas in array literals changing the result of sizeof() #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I don't know if it matters, but if |
Arkshine
added a commit
that referenced
this pull request
Dec 8, 2014
…comma-in-array Fix trailing commas in array literals changing the result of sizeof()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the following SM fix : alliedmodders/sourcemod@099f299 since c++ code is not allowed. So I hope this is not too much dumb conversion and is correct.
This fixes also a crash (assertion) when 3d array with undefined size and trailing comma is used.
Tested with 2d/3d arrays with string and non-string values and this looks good.