Skip to content

Conversation

@luxxxoor
Copy link
Contributor

@luxxxoor luxxxoor commented May 5, 2015

  • Changed format with formatex where needed.
  • Removed many hardcoded contents in plugin.
  • Added semicolons.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you "expand" this condition? It was fine before. No reason to change it.

@luxxxoor luxxxoor closed this May 5, 2015
@Arkshine
Copy link
Member

Arkshine commented May 5, 2015

Why did you close the PR?

@luxxxoor
Copy link
Contributor Author

luxxxoor commented May 6, 2015

I pressed the wrong button from phone, i think the "expand" was needed to understand the code more easier

@luxxxoor luxxxoor reopened this May 6, 2015
@Arkshine
Copy link
Member

Arkshine commented May 6, 2015

I think honestly it does the reverse. You see all conditions on the same level, which is more readable, and unless it's really needed (like logic issue), I would not change them.

@luxxxoor
Copy link
Contributor Author

luxxxoor commented May 6, 2015

For me it is a lot easier to understand the code if it is explained, but if you think the expand will do the reverse i will return to the standard. And i want to know if all the expands are bad (not easy readable) or just some of them ?

@Arkshine
Copy link
Member

In this context, there is no meaning to do that. I would prefer you revert it. Also this is not of matter of bad or something, when conditions are simple and can be aligned to have a better overview, this is more readable. If conditions are complex or long, you can expand so it's easier to understand ; just a matter of context.

Squashing your commits to one would be appreciated.

@Arkshine
Copy link
Member

Why did you revert ALL the changes about the added parenthesis? Did I mention you to revert that? I've SPECIFICALLY pointed above the lines where EXACTLY I would expect some changes... If I did not commented on the others lines, it means It was okay, why are you doing unnecessary changes now?

@luxxxoor
Copy link
Contributor Author

Now is ok ? If it's ok i will squash the commits.

@Arkshine
Copy link
Member

Yes.

Changed format with formatex where needed, removed many hardcoded contents in plugin and added semicolons.
@Arkshine
Copy link
Member

Thanks!

Arkshine added a commit that referenced this pull request May 17, 2015
@Arkshine Arkshine merged commit b364506 into alliedmodders:master May 17, 2015
@luxxxoor luxxxoor deleted the patch-2 branch December 19, 2015 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants