Skip to content

Re-add missing GetEconItemView param (fixes #1001).#1017

Merged
psychonic merged 1 commit intomasterfrom
fix-1001
May 15, 2019
Merged

Re-add missing GetEconItemView param (fixes #1001).#1017
psychonic merged 1 commit intomasterfrom
fix-1001

Conversation

@psychonic
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@Headline Headline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna hide now

@TheDS1337
Copy link
Copy Markdown
Contributor

You may also wanna change these two to PassType_Float:

pass[0].type = PassType_Basic; \

and

pass[0].type = PassType_Basic; \

@psychonic
Copy link
Copy Markdown
Member Author

@TheDS1337 good catch. Do you mind filing a separate issue (or PR?) since it's not directly related to this change?

I think that the difference there only matters for return type, which would explain why that never caused an issue, but it's still wrong and should get fixed.

@TheDS1337
Copy link
Copy Markdown
Contributor

@TheDS1337 good catch. Do you mind filing a separate issue (or PR?) since it's not directly related to this change?

I think that the difference there only matters for return type, which would explain why that never caused an issue, but it's still wrong and should get fixed.

Sure, I will do it

@psychonic psychonic merged commit 7e41893 into master May 15, 2019
@psychonic psychonic deleted the fix-1001 branch May 15, 2019 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants