Skip to content

refactor(provider): remove residual ADR-017 plumbing#62

Merged
giunatale merged 7 commits into
mainfrom
giunatale/remove-residual-adr017
Jul 9, 2026
Merged

refactor(provider): remove residual ADR-017 plumbing#62
giunatale merged 7 commits into
mainfrom
giunatale/remove-residual-adr017

Conversation

@giunatale

Copy link
Copy Markdown
Contributor

Closes #60

ADR-017 (inactive provider validators) was already declared removed in DESIGN_RATIONALE.md, but its MaxProviderConsensusValidators cap and the ComputeNextValidators machinery were left behind. The cap was inert — the default (180) is never below staking MaxValidators, so it never truncated anything — yet the docs still described the consumer set as "capped".

This finishes the removal:

  • Deletes the max_provider_consensus_validators param (incl. proto) and the
    GetMaxProviderConsensusValidators getter.
  • Deletes ComputeNextValidators / GetLastProviderConsensusActiveValidators;
    the consumer set is now the full bonded set (relay + genesis iterate it
    directly), and the provider consensus set follows staking MaxValidators.
  • Removes the two cap-only invariants and the capped staking-keeper shim
    (never wired into mint/distribution — the app injects StakingKeeper).
  • Updates the docs to describe the uncapped, full-set behavior.

@tbruyelle tbruyelle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleaning, a few non-blocking comments.

Comment thread x/vaas/provider/keeper/genesis.go Outdated
Comment thread x/vaas/provider/keeper/validator_set_update.go Outdated
@giunatale giunatale merged commit d79c246 into main Jul 9, 2026
4 checks passed
@giunatale giunatale deleted the giunatale/remove-residual-adr017 branch July 9, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove residual ADR-017 plumbing: MaxProviderConsensusValidators and ComputeNextValidators

3 participants