refactor(provider): remove residual ADR-017 plumbing#62
Merged
Conversation
tbruyelle
approved these changes
Jul 8, 2026
tbruyelle
left a comment
Contributor
There was a problem hiding this comment.
Nice cleaning, a few non-blocking comments.
julienrbrt
approved these changes
Jul 8, 2026
tbruyelle
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60
ADR-017 (inactive provider validators) was already declared removed in
DESIGN_RATIONALE.md, but itsMaxProviderConsensusValidatorscap and theComputeNextValidatorsmachinery were left behind. The cap was inert — the default (180) is never below stakingMaxValidators, so it never truncated anything — yet the docs still described the consumer set as "capped".This finishes the removal:
max_provider_consensus_validatorsparam (incl. proto) and theGetMaxProviderConsensusValidatorsgetter.ComputeNextValidators/GetLastProviderConsensusActiveValidators;the consumer set is now the full bonded set (relay + genesis iterate it
directly), and the provider consensus set follows staking
MaxValidators.(never wired into mint/distribution — the app injects
StakingKeeper).