refactor(auth): deepen audit-log verification behind a shared core - #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
verifyAuditSignature+ asignatureStatusenum) that bothVerifyIntegrity(single) andVerifyBatch(batch) route through, so the tamper-detection logic has one locality instead of two divergent copies.invalid_count. It now reports them in their ownkek_missing_count/kek_missing_logsbucket, agreeing with single-log verification (ErrKekNotFoundForLog). A KEK-missing log still fails the integrity check (it cannot be proven authentic) — only the classification differs.verify-audit-logstext + JSON output gains theKek Missing/kek_missing_*fields.Validation
go test ./internal/auth/... ./cmd/...TestAuditLogSignaturepasses against Postgres (make test-db-up/go test -tags integration ./test/integration/ -run TestAuditLogSignature/make test-db-down)go build ./...,go vet,gofmtcleanDocumentation Quality Gate
docs/cli-commands.mdJSON example)Last updatedmetadata refreshed in changed docs pages — n/a, no such metadata indocs/cli-commands.mdCHANGELOG.mdupdated for significant docs changes — added an Unreleased entrymake docs-lintpasses locally — not run (docker-dependent)