Legacy "manufact" naming cleanup + delegate_gemini resume fix + recreate lockfile workflow (PR-based) - #17
Merged
Merged
Conversation
…sponse, startup log) -- x-manufact-key auth header left untouched, see Notion audit doc
…mcp-server log string
… -> madmcp, 2.0.0 -> 2.1.0) so npm ci stays in sync instead of falling back to npm install on every CI run
…em/tools.js comments and runtime warning text (no live Mem0 entity currently exists under the old names, confirmed via mem0_search)
…ION FIX comments and the add-then-verify comment (line-wrapped, missed by earlier grep)
…from manufact-mcp-server to madmcp-server (cosmetic only — does not change the deploy URL path or break the button)
… is genuinely ignored on a live resume, per runInvestigation), add a runtime guard for the fresh-run case where neither task nor a resumable checkpoint is available, and stop assuming task is always a string in the Notion-logging title. See Notion: madmcp-delegate-gemini-resume-fix-plan
….js can log/title a resumed run without guessing), and inject a step-budget reminder into the last 1-2 remaining steps so a rushed synthesis announces itself as incomplete instead of silently presenting a truncated answer as final. See Notion: madmcp-delegate-gemini-resume-fix-plan
The prior version (removed in PR #10) pushed the regenerated lockfile straight to main via GITHUB_TOKEN, which doesn't trigger other workflows -- so its own commits never got the required "test" check and were likely to be blocked by the branch ruleset. This version opens a PR instead (via peter-evans/create-pull-request), so normal push/pull_request CI runs on it like any other change. See Notion: madmcp-delegate-gemini-resume-fix-plan page's sibling context and PR #10 for background.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated changesets bundled on this branch (flagged earlier during review — worth knowing, not worth splitting now):
1. Legacy "manufact" naming cleanup
Renames every remaining self-referential "manufact" occurrence to "madmcp" across the codebase — service names, User-Agent strings, error messages, a telemetry query-id prefix, stale plan-name references in comments, and the Vercel deploy button's suggested project name.
Deliberately left untouched (per the original audit + confirmed still necessary):
x-manufact-keyHTTP header inconfig.js/server.js— this is the live auth mechanism, possibly a Manufact Cloud platform convention.Full audit: madmcp: legacy "manufact" naming audit (Notion).
2. delegate_gemini resume bug fix
Fixes a schema/docs contradiction where
taskwas required by the tool's Zod schema even onresume_run_idcalls, where it's supposed to be (and, per the loop logic, genuinely is) ignored. Also adds a step-budget reminder late in a run so a rushed synthesis under a tight remaining step count announces itself as incomplete instead of silently truncating the requested output format.Full writeup: BUG: delegate_gemini resume — required "task" schema contradicts docs + step-budget-induced answer truncation (Notion).
3. Generate lockfile workflow, recreated (PR-based)
generate-lockfile.ymlwas removed in #10 because it pushed straight tomainviaGITHUB_TOKEN, which doesn't trigger other workflows -- so its own commits never got the requiredtestcheck and were likely to be blocked by the branch ruleset. Recreated here to open a PR instead (peter-evans/create-pull-request), so normal CI runs on it like any human-authored change.All CI runs on this branch have been green throughout, most recently #140 on the head commit.