feat: read Hermes state.db with node:sqlite, drop better-sqlite3 - #36
Merged
Conversation
better-sqlite3 is a native addon: npm install fails on machines without a compiler toolchain / prebuilt binary (Windows, Alpine, new Node majors). node:sqlite is built into Node >= 22.13 and covers everything the Hermes reader uses (read-only open, prepare/all/get). engines.node bumped to match. New test/hermes.test.js seeds a real state.db in the temp HOME and covers list / detail / 404 / LIKE-fallback search through the HTTP API; Hermes had no integration coverage before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
better-sqlite3is a native addon;npm installfails wherever there's no prebuilt binary or compiler (Windows without build tools, Alpine, a new Node major). For a log viewer, install failure is the whole first impression.node:sqliteis built into Node ≥ 22.13 and covers everything the Hermes reader uses (read-only open,prepare().all/get).engines.nodeand the README badge bumped to 22.13; CI already runs Node 22.Hermes had no integration coverage —
test/hermes.test.jsseeds a realstate.dbinto the temp HOME and exercises list / detail / 404 / LIKE-fallback search through the HTTP API. 124/124 tests pass withbetter-sqlite3absent fromnode_modules. Startup no longer prints anything for the onenode:sqliteExperimentalWarning.