Skip to content

Feature/engines-instead-of-dev-engines - #311

Merged
allohamora merged 1 commit into
masterfrom
feature/engines-instead-of-dev-engines
Aug 27, 2026
Merged

Feature/engines-instead-of-dev-engines#311
allohamora merged 1 commit into
masterfrom
feature/engines-instead-of-dev-engines

Conversation

@allohamora

@allohamora allohamora commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Task

  • Replace devEngines with engines and packageManager

Summary by CodeRabbit

  • New Features

    • JavaScript project setup now configures Node.js and npm version requirements under engines.
    • Adds a top-level packageManager declaration with the configured npm version.
  • Updates

    • Replaced the previous development-engine configuration with the standard package manifest fields.
    • Updated generated package configuration to use the current Node.js and npm versions.

devEngines is a newer, less-stable npm field. engines + packageManager
is the established, widely-supported combo, so both this repo's own
package.json and the CLI's scaffolding preset (dev-engines -> engines)
move back to it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@allohamora
allohamora requested a lite review from Copilot August 27, 2026 09:52
@github-actions github-actions Bot changed the title feat: replace devEngines with engines and packageManager Feature/engines-instead-of-dev-engines Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4c6af2df-a290-4758-9d44-d58dc8d08a33

📥 Commits

Reviewing files that changed from the base of the PR and between 9d811a2 and b39c14b.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (5)
  • README.md
  • __tests__/unit/categories/js/engines/engines.installer.spec.ts
  • package.json
  • src/categories/js/engines/engines.installer.ts
  • src/categories/js/index.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The JavaScript devEngines installer is renamed to engines. It now writes top-level engines and packageManager fields with current Node and npm versions. The registry, package metadata, unit test, and README use the new format.

Changes

JavaScript engine configuration

Layer / File(s) Summary
Update engine output and registration
package.json, src/categories/js/engines/engines.installer.ts, src/categories/js/index.ts
The installer writes Node and npm ranges under engines and writes npm@11.11.0 to packageManager. The JavaScript registry invokes engines, and package metadata uses the same fields.
Align tests and option documentation
__tests__/unit/categories/js/engines/engines.installer.spec.ts, README.md
The unit test validates the new output. The README renames the option and documents the generated fields.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b39c1

This PR replaces the JavaScript package metadata from devEngines to engines and packageManager while updating related implementation names, tests, exports, and documentation. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: replacing devEngines with engines. It is specific and directly matches the pull request objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/engines-instead-of-dev-engines

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The rename and behavior change are consistently applied across implementation, docs, package metadata, and unit tests with no remaining references to the removed devEngines option.

Pull request overview

This PR updates the JS category installer and project metadata to replace the legacy devEngines field with standard package.json engines plus a packageManager pin, aligning the CLI’s generated project setup with common Node.js ecosystem conventions.

Changes:

  • Renames the JS installer from devEngines to engines and updates the JS category registry to expose the new option.
  • Updates the installer logic to write engines.node, engines.npm, and packageManager into package.json.
  • Updates docs, tests, and lockfile metadata to reflect the new fields.
File summaries
File Description
src/categories/js/index.ts Switches the exported JS option from devEngines to engines in the installers registry.
src/categories/js/engines/engines.installer.ts Writes engines and packageManager fields based on the current Node/NPM versions.
README.md Renames the documented option from dev-engines to engines and updates its description.
package.json Replaces devEngines with engines and adds packageManager.
package-lock.json Adds the root package engines metadata consistent with package.json.
tests/unit/categories/js/engines/engines.installer.spec.ts Updates unit test coverage for the new engines/packageManager behavior.
Review details
  • Files reviewed: 5/6 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@allohamora
allohamora merged commit d55f794 into master Aug 27, 2026
6 checks passed
@allohamora
allohamora deleted the feature/engines-instead-of-dev-engines branch August 27, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants