Feature/engines-instead-of-dev-engines - #311
Conversation
devEngines is a newer, less-stable npm field. engines + packageManager is the established, widely-supported combo, so both this repo's own package.json and the CLI's scaffolding preset (dev-engines -> engines) move back to it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe JavaScript ChangesJavaScript engine configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR replaces the JavaScript package metadata from devEngines to engines and packageManager while updating related implementation names, tests, exports, and documentation. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The rename and behavior change are consistently applied across implementation, docs, package metadata, and unit tests with no remaining references to the removed devEngines option.
Pull request overview
This PR updates the JS category installer and project metadata to replace the legacy devEngines field with standard package.json engines plus a packageManager pin, aligning the CLI’s generated project setup with common Node.js ecosystem conventions.
Changes:
- Renames the JS installer from
devEnginestoenginesand updates the JS category registry to expose the new option. - Updates the installer logic to write
engines.node,engines.npm, andpackageManagerintopackage.json. - Updates docs, tests, and lockfile metadata to reflect the new fields.
File summaries
| File | Description |
|---|---|
| src/categories/js/index.ts | Switches the exported JS option from devEngines to engines in the installers registry. |
| src/categories/js/engines/engines.installer.ts | Writes engines and packageManager fields based on the current Node/NPM versions. |
| README.md | Renames the documented option from dev-engines to engines and updates its description. |
| package.json | Replaces devEngines with engines and adds packageManager. |
| package-lock.json | Adds the root package engines metadata consistent with package.json. |
| tests/unit/categories/js/engines/engines.installer.spec.ts | Updates unit test coverage for the new engines/packageManager behavior. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Task
Summary by CodeRabbit
New Features
engines.packageManagerdeclaration with the configured npm version.Updates