feat: support for diesel @ 2.2#404
Conversation
| /// [std-overflow]: https://doc.rust-lang.org/reference/expressions/operator-expr.html#overflow | ||
| #[derive(Clone, Copy, Eq, PartialEq, Hash)] | ||
| #[cfg_attr(feature = "diesel", derive(diesel::AsExpression, diesel::FromSqlRow))] | ||
| #[cfg_attr(feature = "diesel", diesel(sql_type = diesel::sql_types::Binary))] |
There was a problem hiding this comment.
I would prefer not to have these leak into the codebase, is it possible to expand these and include them in the support/diesel.rs file? How many LoC would that add?
There was a problem hiding this comment.
Just pushed up these changes! 😁
It adds ~125 LoC (see latest commit):
Tested with my demo repo against a fresh DB and regenerating migrations to sanity check! 🫡
There was a problem hiding this comment.
cool. I will review, and may do a style pass on the generated code if you don't mind
There was a problem hiding this comment.
Yes of course, feel free-- I mostly kept it the same as the generated code, minus deduping some long namespaced variables. Lmk if I can adjust anything else! 🫡
Thanks James 😁
|
|
||
| ### Added | ||
|
|
||
| - Support for diesel @ 2.2 ([#404]) |
|
why does it merge if clippy fails -_- |
3 participants
Motivation
I noticed there were some comment notes in the repo indicating a desire for diesel support. I had implemented something similar using a newtype pattern in my own project, so I figured I'd attempt to contribute it back upstream.
Solution
This PR implements the required traits for the generic uint types to work out of the box with diesel. The implementation closely matches the sqlx feature implementation in this repo. I have an example repo illustrating simple usage (schema, querying, inserting) @ https://github.com/sinasab/diesel_uint_test/.
PR Checklist